simplify wallet-preparation to 1:1, remove random chooser#629
Merged
Conversation
parkan
force-pushed
the
feat/remove-random-wallet-chooser
branch
2 times, most recently
from
6a81dc4 to
96fa4fc
Compare
parkan
force-pushed
the
feat/remove-random-wallet-chooser
branch
from
96fa4fc to
366e0e5
Compare
anjor
approved these changes
Feb 26, 2026
Collaborator
anjor
left a comment
anjor
left a comment
There was a problem hiding this comment.
Approved.
Non-blocking follow-ups:
- In migrateWalletAssignments, consider guarding against 0-row UPDATEs for stale/malformed wallet_assignments rows before dropping the table, to avoid silent data loss in edge-case legacy DBs.
- Add migration-focused tests for wallet_assignments -> preparations.wallet_id (single wallet, multi-wallet, and malformed legacy rows) to harden this schema transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiple wallets per prep only made sense with DatacapWalletChooser which was never wired. RandomWalletChooser had unclear purpose