Treat JsonNull as null value in FillNullOrEmpty directive#423
Open
DougHamil wants to merge 1 commit intodata-integrations:developfrom
Open
Treat JsonNull as null value in FillNullOrEmpty directive#423DougHamil wants to merge 1 commit intodata-integrations:developfrom
DougHamil wants to merge 1 commit intodata-integrations:developfrom
Conversation
shwei
approved these changes
Jan 13, 2022
shwei
approved these changes
Jan 13, 2022
shwei
left a comment
shwei
left a comment
There was a problem hiding this comment.
The addition of checking for JsonNull has been tested and verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that using the parse-as-json directive can result in cells with JsonNull values that cannot be altered through the fill-null-or-empty directive. This change checks for JsonNull objects and treats them as a null value.