Support skipping dtypes by setting ARRAY_API_TESTS_SKIP_DTYPES - #266
Merged
Conversation
This requires using dtype strategies from hh instead of xps. This also fixes some functions in linalg and fft that were incorrectly only tested against real floating-point dtypes, due to Hypothesis's confusing nomenclature of "floating_dtypes" being only real floating-point dtypes (and this also eliminates the use of Hypothesis's confusing "scalar_dtypes"). Fixes data-apis#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires using dtype strategies from hh instead of xps.
This also fixes some functions in linalg and fft that were incorrectly only tested against real floating-point dtypes, due to Hypothesis's confusing nomenclature of "floating_dtypes" being only real floating-point dtypes (and this also eliminates the use of Hypothesis's confusing "scalar_dtypes").
Fixes #265