Skip to content

Add explicit check for name not None #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crusaderky merged 1 commit into from
May 19, 2026
Merged

Add explicit check for name not None #9265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions distributed/tests/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,6 +2160,16 @@ def get_thread_name():
result = await c.gather(c.submit(get_thread_name, pure=False))
assert "WorkerName-Dask-Default-Threads" in result

# LocalCluster by default assigns numbers starting from zero
# as the worker names
async with Worker(
s.address,
nthreads=1,
name=0,
):
result = await c.gather(c.submit(get_thread_name, pure=False))
assert "0-Dask-Default-Threads" in result

async with Worker(
s.address,
nthreads=1,
Expand Down
2 changes: 1 addition & 1 deletion distributed/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ def __init__(

self.name = name

executor_pool_prefix = f"{self.name}-" if self.name else ""
executor_pool_prefix = f"{self.name}-" if self.name is not None else ""
# Common executors always available
self.executors = {
"offload": utils._offload_executor,
Expand Down
Loading