Skip to content

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Jan 29, 2026

More aligns with whats inside and i have a storage::blocks coming to store actual blocks so this gets rid of the name conflict also.

Summary by CodeRabbit

  • Refactor
    • Internal reorganization of storage module structure for improved code organization and maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

More aligns with whats inside and i have a `storage::blocks` coming to store actual blocks so this gets rid of the name conflict also.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Module restructuring refactor that renames and relocates the blocks module to block_headers throughout the storage module, updating corresponding import paths, public re-exports, and trait implementation references to reflect the new module organization.

Changes

Cohort / File(s) Summary
Module Path Reorganization
dash-spv/src/storage/mod.rs
Renamed module declaration from blocks to block_headers; updated imports, public re-exports, and trait implementations to reference the new module path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops of glee through storage lanes,
Blocks become headers, renamed with care,
Paths reorganized without strains,
New structure shines, fresh as spring air!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: renaming the storage::blocks module to storage::block_headers.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini
Copy link
Collaborator

the filter mod stores the filters and the filters headers, why not the same with the blocks??, or maybe change the filters/filters_headers too, we have to keep consistency

@xdustinface
Copy link
Collaborator Author

the filter mod stores the filters and the filters headers, why not the same with the blocks??

I think it's cleaner to have one storage type per file.

or maybe change the filters/filters_headers too, we have to keep consistency

See #395

@xdustinface xdustinface merged commit 76d565b into v0.42-dev Jan 29, 2026
53 checks passed
@xdustinface xdustinface deleted the chore/rename-block-header-storage branch January 29, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants