ci: exclude draft PRs from test-suite-gate approval requirement#3207
ci: exclude draft PRs from test-suite-gate approval requirement#3207thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
Conversation
The build-images-gate already excludes draft PRs with `!github.event.pull_request.draft` but test-suite-gate was missing this check. Add it for consistency between the two approval gates. Addresses CodeRabbit feedback from dashpay#3185.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test-suite-gate job in the GitHub Actions workflow now excludes draft pull requests from the approval gating logic by adding a condition that checks Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-up to #3185 — adds draft PR exclusion to
test-suite-gatefor consistency withbuild-images-gate.build-images-gateexplicitly excludes draft PRs with!github.event.pull_request.draft, buttest-suite-gatewas missing this check. Draft PRs shouldn't trigger the manual approval gate.Changes
Single-line addition to
.github/workflows/tests.yml: added&& !github.event.pull_request.draftto thetest-suite-gatejob'sifcondition.Validation
Summary by CodeRabbit