Skip to content

ci: exclude draft PRs from test-suite-gate approval requirement#3207

Draft
thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
thepastaclaw:ci/test-suite-gate-draft-check
Draft

ci: exclude draft PRs from test-suite-gate approval requirement#3207
thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
thepastaclaw:ci/test-suite-gate-draft-check

Conversation

@thepastaclaw
Copy link
Contributor

@thepastaclaw thepastaclaw commented Mar 6, 2026

Summary

Follow-up to #3185 — adds draft PR exclusion to test-suite-gate for consistency with build-images-gate.

build-images-gate explicitly excludes draft PRs with !github.event.pull_request.draft, but test-suite-gate was missing this check. Draft PRs shouldn't trigger the manual approval gate.

Changes

Single-line addition to .github/workflows/tests.yml: added && !github.event.pull_request.draft to the test-suite-gate job's if condition.

Validation

  • YAML syntax validated
  • Both gate jobs now have matching draft PR exclusion conditions

Summary by CodeRabbit

  • Chores
    • Updated test suite gate to exclude draft pull requests from approval requirements.

The build-images-gate already excludes draft PRs with
`!github.event.pull_request.draft` but test-suite-gate was missing
this check. Add it for consistency between the two approval gates.

Addresses CodeRabbit feedback from dashpay#3185.
@github-actions github-actions bot added this to the v3.1.0 milestone Mar 6, 2026
@thepastaclaw
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 633994f6-c0fc-4efe-80ad-51d325f37204

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0d5e8aa-0cea-4e17-a88c-7094723ee0e4

📥 Commits

Reviewing files that changed from the base of the PR and between c3e0a83 and c443159.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml

📝 Walkthrough

Walkthrough

The test-suite-gate job in the GitHub Actions workflow now excludes draft pull requests from the approval gating logic by adding a condition that checks !github.event.pull_request.draft.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/tests.yml
Added draft PR exclusion condition (&& !github.event.pull_request.draft) to the test-suite-gate job's conditional logic to prevent test gating from running on draft pull requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A draft comes forth, but wait—hold fast!
No gates shall test what's incomplete,
We filter drafts before they're passed,
Only finished PRs face the feat.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: excluding draft PRs from the test-suite-gate approval requirement in CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant