feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window)#7118
Draft
kwvg wants to merge 31 commits intodashpay:developfrom
Draft
feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window)#7118kwvg wants to merge 31 commits intodashpay:developfrom
kwvg wants to merge 31 commits intodashpay:developfrom
Conversation
|
Collaborator
|
@kwvg would it be difficult to also add the age of the quorums in addition to their health? On testnet some of those quorums haven't formed for years if I'm not mistaken. Would be nice to know if quorums were "fresh" and when the next ones are expected to form. |
|
This pull request has conflicts, please rebase. |
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Feb 12, 2026
…use `UniValue` instead of `QJsonObject`, consistency in tab hiding behavior, minor bugfixes 3329898 chore: remove redundant `std::nullopt` from default init (Kittywhiskers Van Gogh) d9b141a qt: use use `QHash`/`QSet` instead of `std::{map,set}` (Kittywhiskers Van Gogh) ce747c8 qt: add vote signing to wallet interface (Kittywhiskers Van Gogh) 66f2e80 fix: check for `llmq_ctx` before accessing `isman` (Kittywhiskers Van Gogh) ec5fb20 fix: avoid double-free by clearing before dtor semaphore cleanup (Kittywhiskers Van Gogh) 3ee43d9 fix: switch back to overview page if tab disabled (Kittywhiskers Van Gogh) c8ce943 fix: use UniValue instead of QJsonObject to construct proposal (Kittywhiskers Van Gogh) abb9aa1 fix: use wider integer to avoid potential overflow scenarios (Kittywhiskers Van Gogh) 6b90182 fix: acknowledge `updateDIP3List()` fail states (Kittywhiskers Van Gogh) 14b494c fix: avoid potential reassignment of atomic `m_mn_list_changed` (Kittywhiskers Van Gogh) 3b68a2d fix: emit `dataChanged()` when the display unit changes. (Kittywhiskers Van Gogh) 8ab5c0c fix: don't include invisible/hidden tabs in width calculations (Kittywhiskers Van Gogh) 99fd118 fix: avoid precision loss, storing as `CAmount`, fix potential overflow (Kittywhiskers Van Gogh) 72ed0ed fix: remove unused `m_node` in `ProposalWizard` (Kittywhiskers Van Gogh) Pull request description: ## Additional Information Resolution of preexisting bugs in `develop`, review feedback from [dash#7112](#7112) and [dash#7116](#7116) and fixes for bugs discovered when working on [dash#7118](#7118). ## Breaking Changes None expected. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 3329898 knst: utACK 3329898 Tree-SHA512: 5437fa59ae6cd7a7f3d6bfc4167f8562265c0395cd3a92bcbc7c1d97541e25cd373f6f0808d58a503855469875c33d5e08d8b2041fee2c2a001416653f8cca7f
5 tasks
Will be needed as we start consolidating non-wallet data sourcing into a central thread to prevent duplicated fetching. Review with `git log -p -n1 --color-moved=dimmed_zebra --ignore-space-change`.
The current system spins up threads for each wallet instance, this is not sustainable for clients that load a lot of wallets and is computationally expensive for redundant fetches
Same reasoning as previous commit and we consolidate two loops while we're at it. Review with `git log -p -n1 --color-moved=dimmed_zebra --ignore-space-change`.
kwvg
changed the title
This is a preparatory commit needed to switch existing masternode list code to the newly created masternode feed.
All information can be computed at once and selectively discarded so we can avoid potential drift between list changes by making sure direct calls still guarantee that all counts are from the same snapshot
Applying our font causes drift to be introduced for some reason if baked into the layout but this doesn't seem to be an issue if done programmatically
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Also this introduces a new `formatBlockDuration()` which we can use elsewhere to have unified processing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
{Masternode,Proposal}Lists #7146Breaking Changes
None expected.
Checklist