- 
                Notifications
    You must be signed in to change notification settings 
- Fork 47
Move clang-format file into root directory #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
| Codecov Report
 @@              Coverage Diff              @@
##           development     #602    +/-   ##
=============================================
  Coverage        84.95%   84.95%            
=============================================
  Files              316      316            
  Lines            24159    24159            
  Branches         11513    11109   -404     
=============================================
  Hits             20524    20524            
  Misses            3634     3634            
  Partials             1        1 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another two files in the root directory... For what reason did we have the contrib folder?
@rkowalewski : I guess there was once a discussion to move the dev-only stuff to this folder?
| Right now the  | 
| 
 Yup. The original intent was that we do not want to "pollute" our root directory with files which are not a required part of our toolchain. I am also not aware that everybody uses  But for me it's fine that we move it to the root directory and we should definitely use a common formatting. @pascalj and me are using this one in the repository and it is quite pretty. If you have some suggestion feel free to change it. | 
| In my opinion we can move some of the  | 
| small update to our  | 
This PR will make our
.clang-formatrules more visible and easier to use (clang-formatis looking for that file in the current directory or any parent directory)