Skip to content

Bugfix/download button #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025
Merged

Bugfix/download button #5

merged 3 commits into from
Aug 20, 2025

Conversation

KaiwenS7
Copy link
Collaborator

Fix to issue #4
Can be expanded to prevent any similar bugs from cropping up, but currently will work to deal with today's setup

@KaiwenS7 KaiwenS7 added the bug Something isn't working label Aug 14, 2025
@KaiwenS7 KaiwenS7 linked an issue Aug 14, 2025 that may be closed by this pull request
@cpiker
Copy link
Member

cpiker commented Aug 14, 2025

Looking at line 1754 it looks like it would be better if the surrounding python sent the URL stubs (obviously can't send the query params) to the client in advance when generating the js.

There will be one URL stub per download button. Even though many dasFlex setups typically only have one download source, technically there can be an arbitrary number of them for redundancy.

One concern I have is that the content-disposition's filename component is getting ignored somewhere in the form download. The data supplier (d3data.py) sets this using knowledge from the internal.json file on the server, so it's something we want to preserve since the sys-admin for the server has the ability to set filename patterns through that path.

For now I'd like to hold this request open for a more complete fix.

@KaiwenS7
Copy link
Collaborator Author

Takes the content-disposition now for the filename. Also fixes the issue originally brought forward

@cpiker cpiker merged commit dea9937 into main Aug 20, 2025
@cpiker
Copy link
Member

cpiker commented Aug 20, 2025

Branch works fine in the test environment. Verified that both bugs are fixed.

Example filename before the fix:

  • tr-tra_l1a_mag-hsk_flex-undefined_2025-08-19_2025-08-20.das

and after branch install:

  • ts2_l1a_mag_hsk_2025-08-19.d3b

Thanks!

@cpiker cpiker deleted the bugfix/download-button branch August 20, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download button not working for shorter source paths
2 participants