Update builds for SDK assets in tests #2653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `--sound-null-safety` flag. It is currently ignored but will be removed in a future version. - Stop building any SDK .dill files. Some of these were needed for unsound builds after the release of Dart 3.0 but currently the full and outline .dill files are packaged and distributed with the SDK.
bkonyi
approved these changes
Jul 25, 2025
|
Just an FYI I think I will hold of landing this change until https://dart-review.googlesource.com/c/sdk/+/442162 lands and makes it's way into a dev release. More tests should be passing and I hope those timeouts will be resolved too. I want to have a clearer picture to verify that this change isn't causing any new test failures.
Yeah, I'm assuming the formatting changes were from Dart 3.8 as well. I ran a format on save from VS Code and just accepted the result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--sound-null-safetyflag. It is currently ignored but will be removed in a future version.