skip files with only known annotation names #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
approved these changes
Jul 9, 2025
| @@ -6,6 +6,8 @@ | |||
| For questions please use https://github.com/dart-lang/build/discussions. | |||
| - Updated the minimum package versions for a number of dependencies. | |||
| - Require Dart 3.7.0 | |||
| - Update the GeneratorForAnnotation optimization to skip files with well known | |||
There was a problem hiding this comment.
-dev is released, I guess start a block for 3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would bail out early for files with no top level annotations, this also skips well known annotations (although it isn't perfect, and assumes people aren't shadowing these names).