Skip to content

[Dart 3.10] Document dot shorthands #6941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

[Dart 3.10] Document dot shorthands #6941

wants to merge 28 commits into from
+503 −4

Conversation

@connie-ooi
Copy link
Contributor

@connie-ooi connie-ooi commented Oct 14, 2025 •
edited
Loading

Resolves #6285
Resolves #6689

Files changed:

  • examples/language/lib/classes/shorthand.dart
  • src/content/language/dot-shorthands.md
  • src/content/language/enums.md
  • src/content/language/extension-methods.md
  • src/content/language/index.md
  • src/data/sidenav.yml

Link to page previews:

@connie-ooi connie-ooi marked this pull request as draft October 14, 2025 22:27
kallentu
kallentu reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for writing this up.

src/content/language/dot-shorthand.md Outdated
child: Text('Hello')
)
);
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't know if we do this, but do we ever link to the actual spec in documentation? I feel like if users wanted a full, exhaustive rundown of the feature, it'd be nice to get to the spec to read. @antfitch Do you have any guidance here?

Copy link
Collaborator

@antfitch antfitch Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I absolutely think we should do this. Spec: https://github.com/dart-lang/language/blob/main/accepted/3.10/dot-shorthands/feature-specification.md

@antfitch
Copy link
Collaborator

@connie-ooi and @kallentu, after you've finished your review, let me know and I'll start my review. I'll be focusing on flow. If any technical changes are required, @kallentu, I'll pull you in.

@connie-ooi connie-ooi self-assigned this Oct 22, 2025
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Oct 22, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit f3889af):

https://dart-dev--pr6941-dotshorthands-9ckdrfhh.web.app

kallentu
kallentu reviewed Oct 23, 2025
View reviewed changes
kallentu
kallentu approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for making all the changes.

@connie-ooi connie-ooi changed the title add initial draft of dot shorthands feature add dot shorthands feature Oct 27, 2025
@antfitch antfitch changed the title add dot shorthands feature [Dart 3.10] dot shorthands feature Oct 27, 2025
parlough
parlough reviewed Oct 28, 2025
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work on this @connie-ooi! I love it so far :D

I haven't looked through all of the code yet, but I wanted to leave some initial comments and questions until I have time to do so:

@parlough parlough marked this pull request as ready for review October 28, 2025 16:41
@parlough parlough changed the title [Dart 3.10] dot shorthands feature [Dart 3.10] Document dot shorthands Oct 28, 2025
antfitch
antfitch reviewed Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have a few structural changes and additions related to rules.

@connie-ooi @parlough
Update src/data/sidenav.yml
83efd2d 
Co-authored-by: Parker Lougheed <[email protected]>
connie-ooi and others added 14 commits October 29, 2025 10:11
@connie-ooi @parlough
Update src/content/language/dot-shorthands.md
ded2a61 
Co-authored-by: Parker Lougheed <[email protected]>
@connie-ooi @parlough
Update src/content/language/dot-shorthands.md
f3852f5 
Co-authored-by: Parker Lougheed <[email protected]>
@connie-ooi @parlough
Update examples/language/lib/classes/shorthand.dart
7f3f381 
Co-authored-by: Parker Lougheed <[email protected]>
@connie-ooi @parlough
Update src/content/language/dot-shorthands.md
575a975 
Co-authored-by: Parker Lougheed <[email protected]>
@connie-ooi @parlough
Update src/content/language/extension-methods.md
fe0a105 
Co-authored-by: Parker Lougheed <[email protected]>
@connie-ooi @parlough
Update src/content/language/enums.md
2345e51 
Co-authored-by: Parker Lougheed <[email protected]>
@connie-ooi @antfitch
Update usage section
03bc858 
Co-authored-by: Amanda Fitch <[email protected]>
@connie-ooi @antfitch
Update src/content/language/dot-shorthands.md
9ba3572 
Co-authored-by: Amanda Fitch <[email protected]>
@connie-ooi @antfitch
Update src/content/language/dot-shorthands.md
25c1786 
Co-authored-by: Amanda Fitch <[email protected]>
@connie-ooi @antfitch
Update src/content/language/dot-shorthands.md
a321f11 
Co-authored-by: Amanda Fitch <[email protected]>
@connie-ooi @antfitch
Update src/content/language/dot-shorthands.md
860442c 
Co-authored-by: Amanda Fitch <[email protected]>
@connie-ooi @antfitch
Update src/content/language/dot-shorthands.md
2ef50c2 
Co-authored-by: Amanda Fitch <[email protected]>
@connie-ooi
update dotshorthands
9116923
@connie-ooi
update to code files and content
989f2a6
antfitch
antfitch approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! When @parlough has given final signoff, merge this ASAP. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kallentu kallentu kallentu approved these changes

@parlough parlough parlough left review comments

@antfitch antfitch antfitch approved these changes

Assignees

@connie-ooi connie-ooi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dart 3.10 Dot Shorthands [Dot Shorthands] Add Dot Shorthands to the language docs

5 participants

@connie-ooi @antfitch @dart-github-bot @kallentu @parlough