-
Notifications
You must be signed in to change notification settings - Fork 165
Refactor Github Actions + remove mono_repo #8963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
428d92a
to
6800aae
Compare
tool/run-pub-in-all.sh
Outdated
@@ -0,0 +1,19 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
pub upgrade
in the root should upgrade the entire workspace.
@@ -0,0 +1,9 @@ | |||
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be part of this PR?
|
||
/// The timeout factor that should be used in integration tests. | ||
final testTimeoutFactor = 6; | ||
final testTimeoutFactor = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belonging to a different PR?
import 'package:puppeteer_screenshots/puppeteer_utils.dart'; | ||
import 'package:retry/retry.dart'; | ||
|
||
/// Filters server or client messages, ignoring and not reporting them as errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belonging to a different PR?
|
||
setUpAll(() async { | ||
fakeTestScenario = await TestContextProvider.start(); | ||
fakeTestScenario = await TestContextProvider.start( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belonging to a different PR?
strategy: | ||
fail-fast: false | ||
matrix: | ||
package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this can be computed dynamically, but we have dart pub workspace list --json
to list all the packages in the workspace.
The seemingly unrelated changes are part of the PR, because the
|
mono_repo
dependency (tool/run-pub-in-all.sh
to keep the most used feature).