Skip to content

New isolate for the SDK index in the search instance. #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented May 29, 2025

  • part of SDK search index improvements (tracking issue) #8670
  • on a local benchmark, this removed about 5-8% of the overall wall-clock latency with a single thread load, I think the effect may be more with the real traffic which will have higher concurrency
  • This PR refactored PackageIndexHolder and SearchResultCombiner, but mostly kept them in place. I think we should probably merge those, and make other parts simpler (planned in a follow-up PR).
  • note: we (still) lack the test coverage for the entrypoint/search.dart file, will address that in a follow-up PR

@isoos isoos requested review from jonasfj and sigurdm May 29, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant