-
Notifications
You must be signed in to change notification settings - Fork 77
[jni] Fix the context when using multiple flutter engines #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HosseinYousefi
wants to merge
5
commits into
main
Choose a base branch
from
fix-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
API leaks
|
Package | Leaked API symbol | Leaking sources |
---|---|---|
jni | JObjType | jarray.dart::JArrayNullableType types.dart::JObjType::superType types.dart::JObjType::nullableType jobject.dart::JObject::type jobject.dart::JObject::nullableType jobject.dart::JObject::isA::type jobject.dart::JObject::as::type jarray.dart::JArray::type::innerType jarray.dart::JArrayType jarray.dart::JArrayType::superType jarray.dart::JArrayType::nullableType jarray.dart::JArray::nullableType::innerType jarray.dart::JArray::filled::E jarray.dart::JArray::of::elementType jarray.dart::JArray::fromReference::elementType jarray.dart::JArray::new::elementType jarray.dart::JArrayNullableType::superType jarray.dart::JArrayNullableType::nullableType jarray.dart::JBooleanArrayNullableType jarray.dart::JBooleanArrayNullableType::superType jarray.dart::JBooleanArrayNullableType::nullableType jarray.dart::JBooleanArrayType jarray.dart::JBooleanArrayType::superType jarray.dart::JBooleanArrayType::nullableType jarray.dart::JByteArrayNullableType jarray.dart::JByteArrayNullableType::superType jarray.dart::JByteArrayNullableType::nullableType jarray.dart::JByteArrayType jarray.dart::JByteArrayType::superType jarray.dart::JByteArrayType::nullableType jarray.dart::JCharArrayNullableType jarray.dart::JCharArrayNullableType::superType jarray.dart::JCharArrayNullableType::nullableType jarray.dart::JCharArrayType jarray.dart::JCharArrayType::superType jarray.dart::JCharArrayType::nullableType jarray.dart::JShortArrayNullableType jarray.dart::JShortArrayNullableType::superType jarray.dart::JShortArrayNullableType::nullableType jarray.dart::JShortArrayType jarray.dart::JShortArrayType::superType jarray.dart::JShortArrayType::nullableType jarray.dart::JIntArrayNullableType jarray.dart::JIntArrayNullableType::superType jarray.dart::JIntArrayNullableType::nullableType jarray.dart::JIntArrayType jarray.dart::JIntArrayType::superType jarray.dart::JIntArrayType::nullableType jarray.dart::JLongArrayNullableType jarray.dart::JLongArrayNullableType::superType jarray.dart::JLongArrayNullableType::nullableType jarray.dart::JLongArrayType jarray.dart::JLongArrayType::superType jarray.dart::JLongArrayType::nullableType jarray.dart::JFloatArrayNullableType jarray.dart::JFloatArrayNullableType::superType jarray.dart::JFloatArrayNullableType::nullableType jarray.dart::JFloatArrayType jarray.dart::JFloatArrayType::superType jarray.dart::JFloatArrayType::nullableType jarray.dart::JDoubleArrayNullableType jarray.dart::JDoubleArrayNullableType::superType jarray.dart::JDoubleArrayNullableType::nullableType jarray.dart::JDoubleArrayType jarray.dart::JDoubleArrayType::superType jarray.dart::JDoubleArrayType::nullableType jimplementer.dart::JImplementer::implement::type jobject.dart::JObjectNullableType jobject.dart::JObjectNullableType::superType jobject.dart::JObjectNullableType::nullableType jobject.dart::JObjectType jobject.dart::JObjectType::superType jobject.dart::JObjectType::nullableType lang/jboolean.dart::JBooleanNullableType lang/jboolean.dart::JBooleanType lang/jboolean.dart::JBooleanType::superType lang/jboolean.dart::JBooleanType::nullableType lang/jboolean.dart::JBooleanNullableType::superType lang/jboolean.dart::JBooleanNullableType::nullableType lang/jbyte.dart::JByteNullableType lang/jnumber.dart::JNumberType lang/jnumber.dart::JNumberType::superType lang/jnumber.dart::JNumberType::nullableType lang/jnumber.dart::JNumberNullableType lang/jnumber.dart::JNumberNullableType::superType lang/jnumber.dart::JNumberNullableType::nullableType lang/jbyte.dart::JByteType lang/jbyte.dart::JByteType::superType lang/jbyte.dart::JByteType::nullableType lang/jbyte.dart::JByteNullableType::superType lang/jbyte.dart::JByteNullableType::nullableType lang/jcharacter.dart::JCharacterNullableType lang/jcharacter.dart::JCharacterType lang/jcharacter.dart::JCharacterType::superType lang/jcharacter.dart::JCharacterType::nullableType lang/jcharacter.dart::JCharacterNullableType::superType lang/jcharacter.dart::JCharacterNullableType::nullableType lang/jdouble.dart::JDoubleNullableType lang/jdouble.dart::JDoubleType lang/jdouble.dart::JDoubleType::superType lang/jdouble.dart::JDoubleType::nullableType lang/jdouble.dart::JDoubleNullableType::superType lang/jdouble.dart::JDoubleNullableType::nullableType lang/jfloat.dart::JFloatNullableType lang/jfloat.dart::JFloatType lang/jfloat.dart::JFloatType::superType lang/jfloat.dart::JFloatType::nullableType lang/jfloat.dart::JFloatNullableType::superType lang/jfloat.dart::JFloatNullableType::nullableType lang/jinteger.dart::JIntegerNullableType lang/jinteger.dart::JIntegerType lang/jinteger.dart::JIntegerType::superType lang/jinteger.dart::JIntegerType::nullableType lang/jinteger.dart::JIntegerNullableType::superType lang/jinteger.dart::JIntegerNullableType::nullableType lang/jlong.dart::JLongNullableType lang/jlong.dart::JLongType lang/jlong.dart::JLongType::superType lang/jlong.dart::JLongType::nullableType lang/jlong.dart::JLongNullableType::superType lang/jlong.dart::JLongNullableType::nullableType lang/jshort.dart::JShortType lang/jshort.dart::JShortType::superType lang/jshort.dart::JShortType::nullableType lang/jshort.dart::JShortNullableType lang/jshort.dart::JShortNullableType::superType lang/jshort.dart::JShortNullableType::nullableType lang/jstring.dart::JStringNullableType lang/jstring.dart::JString::type lang/jstring.dart::JString::nullableType lang/jstring.dart::JStringNullableType::superType lang/jstring.dart::JStringNullableType::nullableType lang/jstring.dart::JStringType lang/jstring.dart::JStringType::superType lang/jstring.dart::JStringType::nullableType nio/jbuffer.dart::JBufferNullableType nio/jbuffer.dart::JBufferType nio/jbuffer.dart::JBufferType::superType nio/jbuffer.dart::JBufferType::nullableType nio/jbuffer.dart::JBufferNullableType::superType nio/jbuffer.dart::JBufferNullableType::nullableType nio/jbyte_buffer.dart::JByteBufferNullableType nio/jbyte_buffer.dart::JByteBufferType nio/jbyte_buffer.dart::JByteBufferType::superType nio/jbyte_buffer.dart::JByteBufferType::nullableType nio/jbyte_buffer.dart::JByteBufferNullableType::superType nio/jbyte_buffer.dart::JByteBufferNullableType::nullableType util/jiterator.dart::JIteratorNullableType util/jiterator.dart::JIterator::type::E util/jiterator.dart::JIteratorType util/jiterator.dart::JIteratorType::superType util/jiterator.dart::JIteratorType::nullableType util/jiterator.dart::JIterator::nullableType::E util/jiterator.dart::JIterator::fromReference::E util/jiterator.dart::JIteratorNullableType::superType util/jiterator.dart::JIteratorNullableType::nullableType util/jlist.dart::JListNullableType util/jlist.dart::JList::type::E util/jlist.dart::JListType util/jlist.dart::JListType::superType util/jlist.dart::JListType::nullableType util/jlist.dart::JList::nullableType::E util/jlist.dart::JList::fromReference::E util/jlist.dart::JList::array::E util/jlist.dart::JListNullableType::superType util/jlist.dart::JListNullableType::nullableType util/jlist.dart::ToJavaList::toJList::type util/jmap.dart::JMapNullableType util/jset.dart::JSet::type::E util/jset.dart::JSetType util/jset.dart::JSetType::superType util/jset.dart::JSetType::nullableType util/jset.dart::JSet::nullableType::E util/jset.dart::JSetNullableType util/jset.dart::JSetNullableType::superType util/jset.dart::JSetNullableType::nullableType util/jset.dart::JSet::fromReference::E util/jset.dart::JSet::hash::E util/jmap.dart::JMap::type::K util/jmap.dart::JMap::type::V util/jmap.dart::JMapType util/jmap.dart::JMapType::superType util/jmap.dart::JMapType::nullableType util/jmap.dart::JMap::nullableType::K util/jmap.dart::JMap::nullableType::V util/jmap.dart::JMap::fromReference::K util/jmap.dart::JMap::fromReference::V util/jmap.dart::JMap::hash::K util/jmap.dart::JMap::hash::V util/jmap.dart::JMapNullableType::superType util/jmap.dart::JMapNullableType::nullableType util/jmap.dart::ToJavaMap::toJMap::keyType util/jmap.dart::ToJavaMap::toJMap::valueType util/jset.dart::ToJavaSet::toJSet::type |
jni | JCallable | types.dart::JObjType types.dart::JInstanceMethodId::call::returnType types.dart::JStaticMethodId::call::returnType jarray.dart::JArrayType jarray.dart::JArrayNullableType jarray.dart::JBooleanArrayNullableType jarray.dart::JBooleanArrayType jarray.dart::JByteArrayNullableType jarray.dart::JByteArrayType jarray.dart::JCharArrayNullableType jarray.dart::JCharArrayType jarray.dart::JShortArrayNullableType jarray.dart::JShortArrayType jarray.dart::JIntArrayNullableType jarray.dart::JIntArrayType jarray.dart::JLongArrayNullableType jarray.dart::JLongArrayType jarray.dart::JFloatArrayNullableType jarray.dart::JFloatArrayType jarray.dart::JDoubleArrayNullableType jarray.dart::JDoubleArrayType jobject.dart::JObjectNullableType jobject.dart::JObjectType types.dart::jbyteType types.dart::jbooleanType types.dart::jcharType types.dart::jshortType types.dart::jintType types.dart::jlongType types.dart::jfloatType types.dart::jdoubleType types.dart::jvoidType lang/jboolean.dart::JBooleanType lang/jboolean.dart::JBooleanNullableType lang/jnumber.dart::JNumberType lang/jnumber.dart::JNumberNullableType lang/jbyte.dart::JByteType lang/jbyte.dart::JByteNullableType lang/jcharacter.dart::JCharacterType lang/jcharacter.dart::JCharacterNullableType lang/jdouble.dart::JDoubleType lang/jdouble.dart::JDoubleNullableType lang/jfloat.dart::JFloatType lang/jfloat.dart::JFloatNullableType lang/jinteger.dart::JIntegerType lang/jinteger.dart::JIntegerNullableType lang/jlong.dart::JLongType lang/jlong.dart::JLongNullableType lang/jshort.dart::JShortType lang/jshort.dart::JShortNullableType lang/jstring.dart::JStringNullableType lang/jstring.dart::JStringType nio/jbuffer.dart::JBufferType nio/jbuffer.dart::JBufferNullableType nio/jbyte_buffer.dart::JByteBufferType nio/jbyte_buffer.dart::JByteBufferNullableType util/jiterator.dart::JIteratorType util/jiterator.dart::JIteratorNullableType util/jlist.dart::JListType util/jlist.dart::JListNullableType util/jset.dart::JSetType util/jset.dart::JSetNullableType util/jmap.dart::JMapType util/jmap.dart::JMapNullableType |
jni | JConstructable | types.dart::JObjType types.dart::JConstructorId::call::returnType jarray.dart::JArrayType jarray.dart::JArrayNullableType jarray.dart::JBooleanArrayNullableType jarray.dart::JBooleanArrayType jarray.dart::JByteArrayNullableType jarray.dart::JByteArrayType jarray.dart::JCharArrayNullableType jarray.dart::JCharArrayType jarray.dart::JShortArrayNullableType jarray.dart::JShortArrayType jarray.dart::JIntArrayNullableType jarray.dart::JIntArrayType jarray.dart::JLongArrayNullableType jarray.dart::JLongArrayType jarray.dart::JFloatArrayNullableType jarray.dart::JFloatArrayType jarray.dart::JDoubleArrayNullableType jarray.dart::JDoubleArrayType jobject.dart::JObjectNullableType jobject.dart::JObjectType lang/jboolean.dart::JBooleanType lang/jboolean.dart::JBooleanNullableType lang/jnumber.dart::JNumberType lang/jnumber.dart::JNumberNullableType lang/jbyte.dart::JByteType lang/jbyte.dart::JByteNullableType lang/jcharacter.dart::JCharacterType lang/jcharacter.dart::JCharacterNullableType lang/jdouble.dart::JDoubleType lang/jdouble.dart::JDoubleNullableType lang/jfloat.dart::JFloatType lang/jfloat.dart::JFloatNullableType lang/jinteger.dart::JIntegerType lang/jinteger.dart::JIntegerNullableType lang/jlong.dart::JLongType lang/jlong.dart::JLongNullableType lang/jshort.dart::JShortType lang/jshort.dart::JShortNullableType lang/jstring.dart::JStringNullableType lang/jstring.dart::JStringType nio/jbuffer.dart::JBufferType nio/jbuffer.dart::JBufferNullableType nio/jbyte_buffer.dart::JByteBufferType nio/jbyte_buffer.dart::JByteBufferNullableType util/jiterator.dart::JIteratorType util/jiterator.dart::JIteratorNullableType util/jlist.dart::JListType util/jlist.dart::JListNullableType util/jset.dart::JSetType util/jset.dart::JSetNullableType util/jmap.dart::JMapType util/jmap.dart::JMapNullableType |
jni | JAccessible | types.dart::JObjType types.dart::JInstanceFieldId::get::type types.dart::JInstanceFieldId::set::type types.dart::JStaticFieldId::get::type types.dart::JStaticFieldId::set::type jarray.dart::JArrayType jarray.dart::JArrayNullableType jarray.dart::JBooleanArrayNullableType jarray.dart::JBooleanArrayType jarray.dart::JByteArrayNullableType jarray.dart::JByteArrayType jarray.dart::JCharArrayNullableType jarray.dart::JCharArrayType jarray.dart::JShortArrayNullableType jarray.dart::JShortArrayType jarray.dart::JIntArrayNullableType jarray.dart::JIntArrayType jarray.dart::JLongArrayNullableType jarray.dart::JLongArrayType jarray.dart::JFloatArrayNullableType jarray.dart::JFloatArrayType jarray.dart::JDoubleArrayNullableType jarray.dart::JDoubleArrayType jobject.dart::JObjectNullableType jobject.dart::JObjectType types.dart::jbyteType types.dart::jbooleanType types.dart::jcharType types.dart::jshortType types.dart::jintType types.dart::jlongType types.dart::jfloatType types.dart::jdoubleType lang/jboolean.dart::JBooleanType lang/jboolean.dart::JBooleanNullableType lang/jnumber.dart::JNumberType lang/jnumber.dart::JNumberNullableType lang/jbyte.dart::JByteType lang/jbyte.dart::JByteNullableType lang/jcharacter.dart::JCharacterType lang/jcharacter.dart::JCharacterNullableType lang/jdouble.dart::JDoubleType lang/jdouble.dart::JDoubleNullableType lang/jfloat.dart::JFloatType lang/jfloat.dart::JFloatNullableType lang/jinteger.dart::JIntegerType lang/jinteger.dart::JIntegerNullableType lang/jlong.dart::JLongType lang/jlong.dart::JLongNullableType lang/jshort.dart::JShortType lang/jshort.dart::JShortNullableType lang/jstring.dart::JStringNullableType lang/jstring.dart::JStringType nio/jbuffer.dart::JBufferType nio/jbuffer.dart::JBufferNullableType nio/jbyte_buffer.dart::JByteBufferType nio/jbyte_buffer.dart::JByteBufferNullableType util/jiterator.dart::JIteratorType util/jiterator.dart::JIteratorNullableType util/jlist.dart::JListType util/jlist.dart::JListNullableType util/jset.dart::JSetType util/jset.dart::JSetNullableType util/jmap.dart::JMapType util/jmap.dart::JMapNullableType |
jni | _JFinalizable | jreference.dart::JReference::new::_finalizable |
jni | _Dart_FinalizableHandle | third_party/jni_bindings_generated.dart::JniBindings::newJObjectFinalizableHandle third_party/jni_bindings_generated.dart::JniBindings::newBooleanFinalizableHandle third_party/jni_bindings_generated.dart::JniBindings::deleteFinalizableHandle::finalizableHandle third_party/jni_bindings_generated.dart::Dart_FinalizableHandle |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/jni/lib/src/third_party/generated_bindings.dart |
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart |
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart |
pkgs/native_doc_dartifier/tool/compile_java.dart |
pkgs/objective_c/lib/src/ns_input_stream.dart |
dbbcc31
to
9eb6750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by flutter/flutter#173474
Also missing integration tests but I will write those when the hot restart problem gets resolved.