Skip to content

Conversation

marshelino-maged
Copy link
Contributor

Here is a link to my fork's PR to show the CI output: https://github.com/marshelino-maged/native/pull/5
Related to #2343
Adding some end-to-end tests that test:

  • The initialization and call to an inner Java class inside some outer class.
  • The use of strings correctly using toJString() and toDartString()
  • The use of identifiers that start with '_'
  • The use of identifiers that have some '$'

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Copy link

github-actions bot commented Jul 17, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ⚠️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/native_doc_dartifier/tool/compile_java.dart

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@HosseinYousefi HosseinYousefi self-requested a review July 21, 2025 13:39
@marshelino-maged
Copy link
Contributor Author

marshelino-maged commented Jul 23, 2025

A small change in tests ... makes all Java snippets used in tests return a boolean value, then in runtime_test.dart only checks if functions return True.

This makes the runtime_test.dart to be low coupled with the java_snippets.dart

Run test cases twice one with the current files in the repo to know if they are outdated and the other one is with the new generated files to know that nothing is break with generation
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jul 23, 2025
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HosseinYousefi
Copy link
Member

Please update the branch with the latest changes.

@marshelino-maged
Copy link
Contributor Author

Please update the branch with the latest changes.

Done

@HosseinYousefi HosseinYousefi merged commit e820406 into dart-lang:main Aug 1, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:native_doc_dartifier type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants