-
Notifications
You must be signed in to change notification settings - Fork 81
[native_doc_dartifier] Adding some End to End tests #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers
|
Files |
---|
pkgs/native_doc_dartifier/tool/compile_java.dart |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/jni/lib/src/third_party/generated_bindings.dart |
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart |
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart |
pkgs/objective_c/lib/src/ns_input_stream.dart |
This check can be disabled by tagging the PR with skip-license-check
.
pkgs/native_doc_dartifier/test/dartify_simple_cases/dartified_snippets/identifiers.dart
Show resolved
Hide resolved
A small change in tests ... makes all Java snippets used in tests return a boolean value, then in This makes the |
Run test cases twice one with the current files in the repo to know if they are outdated and the other one is with the new generated files to know that nothing is break with generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please update the branch with the latest changes. |
Done |
Here is a link to my fork's PR to show the CI output: https://github.com/marshelino-maged/native/pull/5
Related to #2343
Adding some end-to-end tests that test:
toJString()
andtoDartString()