Skip to content

[infra] Remove path dependencies #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

[infra] Remove path dependencies #2179

merged 3 commits into from
Apr 8, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 7, 2025

Bug:

Split off:

This PR removes the path dependencies on package:native_assets_cli and package:native_toolchain_c within the workspace.

For test projects, when copying them over, add dependency_overrides to the right location.

pkgs/native_assets_cli/tool/dependencies.dart is removed. Upgrading dependencies can be done with dart pub upgrade native_assets_cli --tighten --major-versions

Copy link

github-actions bot commented Apr 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes changed the title [infra] remove path dependencies [infra] Remove path dependencies Apr 7, 2025
@dcharkes dcharkes marked this pull request as ready for review April 7, 2025 20:28
@dcharkes dcharkes requested a review from mosuem April 7, 2025 20:28
Base automatically changed from native-workspace to main April 8, 2025 15:11
@auto-submit auto-submit bot merged commit e6549b4 into main Apr 8, 2025
41 checks passed
@auto-submit auto-submit bot deleted the remove-path-deps branch April 8, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants