[jnigen] standardize on using gradle to build all artifacts versus a mix of Maven and Gradle #1948
Conversation
Adds ktor plugin to supply fatjars for ApiSummarizer builds Housekeeping in ApiSummarizer build.gradle.kts
Remove dead code from build.gradle.kts for summarizer.
Dynamically creates a gradle project on the fly allowing the maven dependency to be removed when fully implemented. Added function to create gradle dependency for given library
Change jarDir to absolute path
Dead code cleanup. Making refs to ApiSummarizer work in pub-cache, I think.
Searches multiple locations for gradlew executable
Bump Java version to 11 from 8
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
API leaks
|
| Package | Leaked API symbols |
|---|---|
| jni | _ReferenceType _opaque_pthread_mutex_t _opaque_pthread_cond_t _Dart_FinalizableHandle |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/jni/lib/src/third_party/generated_bindings.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
There was a problem hiding this comment.
Thank you @jwill!
Could you please completely remove MavenTools. Also package:jni uses Maven to build some dependencies for Dart-standalone. While we're at it, we could remove that one and completely get rid of any maven dependencies (The pom.xml is in jni/java. We use it in jni/bin/setup.dart).
Then let's add the changes to both CHANGELOGs and update the readme to reflect that maven is no longer a requirement.
The config can be changed not to use the word "maven" to describe downloading the dependencies, but that's a breaking change that I can do myself in a separate PR, so let's not worry about it now.
Move MavenDependency class definition to gradle_tools.dart Removed unused BuildSummarizer pom.xml Updated jnigen/CHANGELOG.md Updated jnigen/README.md Bump jnigen version.
Remove unneeded pom.xml
It's still using maven repositories so for continuity, it's probably ok to leave the name maven in the config file for clarity. The finalized system won't be using the maven executable but it will be interacting with maven repositories |
|
Unfortunately the GitHub CI needs my approval to run. Can we add all users of Flutter and Dart orgs to ones who can run CI themselves? @mit-mit That said, the tests seem to be failing. Please run dart format to fix the |
Refactor code kotlin_test code to track down jni error
Having CI kickoff perms would definitely help preventable problems like this one where a file excluded by .gitignore caused it to fail. |
|
I can approve the CI every time you add a change, so feel free to commit the fix whenever you find time. |
|
Resolved the conflicts to run the CI. Update: There are still some analysis problems that will mostly go away with |
Include jni.jar in kotlin_test jar Should fix broken runtime tests.
Fix path issue that happens only on Windows
maven_downloadssection of jnigen.yaml (instead of Maven)Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.