Skip to content

[swift2objc] Add support for mutating functions #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

nikeokoronkwo
Copy link
Contributor

Fixes #1737

The changes here address support for mutating functions.
Not much needs to be done in the transformation end, as mutating functions are only allowed on structs and protocols.

@nikeokoronkwo nikeokoronkwo changed the title added support for mutating functions [swift2objc] Add support for mutating functions Jan 27, 2025
@nikeokoronkwo nikeokoronkwo marked this pull request as ready for review January 27, 2025 14:36
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link
Contributor

@liamappelbe liamappelbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs formatting.

@liamappelbe liamappelbe merged commit 6cec710 into dart-lang:main Mar 3, 2025
15 checks passed
@coveralls
Copy link

Coverage Status

coverage: 84.595% (-2.6%) from 87.151%
when pulling 5c2edc1 on nikeokoronkwo:swift2objc-mutating
into 440c0e7 on dart-lang:main.

@nikeokoronkwo nikeokoronkwo deleted the swift2objc-mutating branch March 3, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[swift2objc] Support mutating methods
3 participants