Add comment to package:intl pubspec. #980

mosuem · 2025-06-27T14:25:56Z

To be merged after flutter/flutter#169286

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

github-actions · 2025-06-27T14:26:52Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:intl	0.20.3-wip	WIP (no publish necessary)
package:intl4x	0.11.4	ready to publish	`intl4x-v0.11.4`
package:intl_translation	0.20.1	already published at pub.dev
package:messages_shrinker	0.2.2-wip	WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions · 2025-06-27T14:28:33Z

PR Health

Breaking changes

⚠️

Package	Change	Current Version	New Version	Needed Version	Looking good?
intl	Breaking	0.20.2	0.20.3-wip	0.21.0 Got "0.20.3-wip" expected >= "0.21.0" (breaking changes)	⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ✔️

File	Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks

⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols
intl	StringStack DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Fixes #158050 Created by running `flutter update-packages --cherry-pick=intl:^0.20.2 --exclude-tools` - we probably don't want to unpin `flutter_tools` dependencies to avoid breaking it. Add comment to `package:intl`s pubspec in dart-lang/i18n#980. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

devoncarew

I'm assuming this is necessary for some process, and we plan to remove the comment at some point?

mosuem · 2025-06-30T16:12:35Z

It's just a reminder to be careful and follow semver, nothing more.

devoncarew · 2025-06-30T16:20:38Z

pkgs/intl/pubspec.yaml

@@ -1,5 +1,5 @@
 name: intl
-version: 0.20.3-wip
+version: 0.20.3-wip # This should follow semver to not break Flutter, where it is unpinned, see https://github.com/flutter/flutter/blob/main/pubspec.yaml


Some bikeshedding:

# This package is a dependency of the Flutter framework; changes here should # follow semver. version: 0.20.3-wip

Fixes flutter#158050 Created by running `flutter update-packages --cherry-pick=intl:^0.20.2 --exclude-tools` - we probably don't want to unpin `flutter_tools` dependencies to avoid breaking it. Add comment to `package:intl`s pubspec in dart-lang/i18n#980. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Add comment to package:intl pubspec.

ea01b30

github-actions bot added the package:intl label Jun 27, 2025

mosuem mentioned this pull request Jun 27, 2025

Unpin package:intl flutter/flutter#169286

Merged

9 tasks

mosuem enabled auto-merge (squash) June 27, 2025 14:26

mosuem added the skip-changelog-check label Jun 27, 2025

mosuem requested a review from devoncarew June 30, 2025 08:32

devoncarew approved these changes Jun 30, 2025

View reviewed changes

mosuem merged commit 973f331 into main Jun 30, 2025
19 of 20 checks passed

mosuem deleted the addFlutterMessage branch June 30, 2025 16:11

devoncarew reviewed Jun 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add comment to package:intl pubspec. #980

Add comment to package:intl pubspec. #980

Uh oh!

mosuem commented Jun 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

devoncarew left a comment

Uh oh!

Uh oh!

mosuem commented Jun 30, 2025

Uh oh!

devoncarew Jun 30, 2025

Uh oh!

Uh oh!

Add comment to package:intl pubspec. #980

Add comment to package:intl pubspec. #980

Uh oh!

Conversation

mosuem commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025

Package publishing

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

devoncarew left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mosuem commented Jun 30, 2025

Uh oh!

devoncarew Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mosuem commented Jun 27, 2025 •

edited

Loading

github-actions bot commented Jun 27, 2025 •

edited

Loading