#3180. Add JSFunctionUnsafeUtilExtension tests #3285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujzs
approved these changes
Aug 20, 2025
LibTest/js_interop_unsafe/JSFunctionUnsafeUtilExtension/callAsConstructorVarArgs_A01_t01.dart
Show resolved
Hide resolved
eernstg
reviewed
Aug 21, 2025
LibTest/js_interop_unsafe/JSFunctionUnsafeUtilExtension/callAsConstructor_A02_t01.dart
Show resolved
Hide resolved
LibTest/js_interop_unsafe/JSFunctionUnsafeUtilExtension/callAsConstructor_A01_t02.dart
Outdated
Show resolved
Hide resolved
LibTest/js_interop_unsafe/JSFunctionUnsafeUtilExtension/callAsConstructorVarArgs_A02_t01.dart
Show resolved
Hide resolved
|
Updated. PTAL. |
srujzs
approved these changes
Aug 22, 2025
eernstg
approved these changes
Aug 26, 2025
LibTest/js_interop_unsafe/JSFunctionUnsafeUtilExtension/callAsConstructor_A02_t01.dart
Show resolved
Hide resolved
LibTest/js_interop_unsafe/JSFunctionUnsafeUtilExtension/callAsConstructorVarArgs_A02_t01.dart
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 29, 2025
2025-08-29 [email protected] dart-lang/co19#3180. Add tests for `ObjectToJSBoxedDartObject` (dart-lang/co19#3291) 2025-08-29 [email protected] Fixes dart-lang/co19#3292. Ignore some analyzer warnings, add issue numbers (dart-lang/co19#3295) 2025-08-29 [email protected] dart-lang/co19#3180. Fix delete_A01_t06.dart to work in both strict/non-strict modes (dart-lang/co19#3290) 2025-08-28 [email protected] dart-lang/co19#3292. Update assertions for `reachability_switch_*` tests (dart-lang/co19#3293) 2025-08-27 [email protected] dart-lang/co19#3180. Add tests for `JSObjectUnsafeUtilExtension` (dart-lang/co19#3289) 2025-08-26 [email protected] dart-lang/co19#3180. Add JSFunctionUnsafeUtilExtension tests (dart-lang/co19#3285) 2025-08-26 [email protected] dart-lang/co19#3180. Add `callMethod` and `callMethodVarArgs` tests (dart-lang/co19#3288) 2025-08-25 [email protected] dart-lang/co19#3180. Add tests for `createJSInteropWrapper()` function (dart-lang/co19#3283) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I8188f94fcf0ffbfbb4c117abb80676f9675fb06e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447721 Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Ivan Inozemtsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.