Skip to content

Shutting down daemon process if build_runner throws. #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Shutting down daemon process if build_runner throws. #4274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
163dadc
Shutting down daemon process if build_runner throws.
Markzipan Nov 7, 2025
c134331
ver bump
Markzipan Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_daemon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.1.1

- Bug fix: daemon process shuts down on internal error.

## 4.1.0

- Bug fix: resolve symlinks when identifying workspaces, so symlinks can't
Expand Down
7 changes: 6 additions & 1 deletion build_daemon/lib/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,12 @@ class BuildDaemonClient {
includeParentEnvironment: includeParentEnvironment,
);

await _handleDaemonStartup(process, logHandler);
try {
await _handleDaemonStartup(process, logHandler);
} catch (_) {
process.kill();
rethrow;
}

return connectUnchecked(
workingDirectory,
Expand Down
2 changes: 1 addition & 1 deletion build_daemon/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_daemon
version: 4.1.0
version: 4.1.1
description: A daemon for running Dart builds.
repository: https://github.com/dart-lang/build/tree/master/build_daemon
resolution: workspace
Expand Down