Remove builder options nodes; store and check builder options by phase. #3983
+307
−404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
davidmorgan
force-pushed
the
build-options-to-phases
branch
11 times, most recently
from
fe432fd to
164d4b9
Compare
davidmorgan
force-pushed
the
build-options-to-phases
branch
from
164d4b9 to
c041360
Compare
jensjoha
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Prior to this PR builder options are stored as nodes in the asset graph, with each generation / post generation pointing to its builder options node. This is used to know to rerun generations when builder options change.
Builder options are set per phase in
BuildPhases, so instead map the list of phases to a list of digests, and store/compare that, removing builder options entirely from the asset graph.Checking whether in-build and post build actions rerun when options change is already covered by tests.