Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make changes for Webpack 5 #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make changes for Webpack 5 #46

wants to merge 2 commits into from

Conversation

christiango
Copy link
Contributor

This will address the deprecation warning that comes with Webpack 5. Should resolve #42

@christiango
Copy link
Contributor Author

It seems like the UTs fail in master on Windows. Would be good to confirm if the tests pass in Mac/Linux before and after this change.

@kubijo
Copy link

kubijo commented Oct 27, 2020

I'd like to have this released and I can help you with linux test if you'll hold my hand with the process…

@christiango
Copy link
Contributor Author

I'd like to have this released and I can help you with linux test if you'll hold my hand with the process…

Thanks for the offer! I'm not a maintainer of the project, so I won't be able to merge the PR. But the thing I'd like to confirm here is that the tests pass in master and in this PR branch, as they fail in both places on my windows machine. I just cloned the repo, ran npm install, npm run build, and npm run test. It seems the paths being checked in the tests are Unix paths, but I don't have a Unix machine.

@kubijo
Copy link

kubijo commented Oct 27, 2020 •
edited
Loading

Well ... I'm not sure if this is an OK run, but that's what I get from npm run test both on your version & master…

 λ npm run test

> [email protected] test /home/pepa/dev/duplicate-package-checker-webpack-plugin
> jest test/**/*.test.js --runInBand

(yep, just 3 empty lines)

@mjhenkes
Copy link

mjhenkes commented Dec 7, 2020

FWIW we maintain a fork of this project with webpack 5 support.
https://www.npmjs.com/package/@cerner/duplicate-package-checker-webpack-plugin

@malash
Copy link

malash commented Nov 24, 2021

Any update about this PR? Is it ready to merge into master branch?

This was referenced Apr 13, 2022
Closed
Merged
CraigMacomber added a commit to microsoft/FluidFramework that referenced this pull request Apr 18, 2022
@CraigMacomber
Update misc webpack related packages (#9889)
9b91c92 
As part of the effort to update to webpack5 (#9568) this updates a few webpack related packages, hopefully reducing the number of issues when updating webpack itself.

The most significant change is migrating from duplicate-package-checker-webpack-plugin to its fork @cerner/duplicate-package-checker-webpack-plugin because the original has not merged support for webpack5, see darrenscerri/duplicate-package-checker-webpack-plugin#46

Co-authored-by: Craig Macomber <[email protected]>
Repository owner deleted a comment from 19890843006 Feb 23, 2024
Repository owner deleted a comment from jalamari2018 Mar 19, 2024
Repository owner deleted a comment from jalamari2018 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module.issuer is deprecated in Webpack v5
4 participants
@christiango @kubijo @mjhenkes @malash