Adding in support for detecting duplicates of the same version #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default duplicates of same version of the package will be ignored. To enable the feature pass in ignoreSameVersionDuplicates: false as part of the webpack config for the plugin. Updating snapshot tests to fix bugs found in the tests. Updating readme files.
Author
|
The yarn.lock files updates came when I installed on an ubuntu box, perhaps the original file was checked in on an OSx box? |
added 6 commits
May 9, 2018 14:40
Fixing typo in readme.md.
…oduced by the usage of higher node version on my local box.
Author
|
Had to explicitly specify node versions in the travis.yml file as 10.0 (latest node) seems to have incompatibilities with the current yarn.lock file |
added 9 commits
May 14, 2018 12:35
Adding in an install step, so that the lib folder gets generated on install.
Babel was not being run on yarn install, as the babel was installed outside of the root folder.
TODO: fix this up properly later on.
… pre-publish no longer works on newer versions of npm.
As yarn installs all packages at the root folder, when traversing the module tree, multiple packages will resolve to the same root. Now webpack bundles by path, thus, when used with yarn the modules will only be duplicated if they do not belong to the same path.
This is to fix travis failures on lower versions of npm
|
This works great - thanks @masterkidan! If I had a criticism it would be that it picks up packages in Is this plugin still being maintained @darrenscerri? Is it possible to get this feature merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is to address the issue #19 . Essentially this PR adds a flag
ignoreSameVersionDuplicates, which (if set tofalse) will automatically catch duplicates of the same version of the file when they are added as subdependencies.By default ignoreSameVersionDuplicates is set to false, this is to prevent failures for the existing consumers of this plugin.
The change consists of the following updates as well:
Basically, the test had the following versions of the packages
a -> 1.0.0, 2.0.0, 2.5.0
b -> 1.0.0, 2.0.0
c -> 1.0.0
However the test for strict == false was assuming that there would only be 1 package with a major version change, when there are actually two (as can be seen above).