-
Notifications
You must be signed in to change notification settings - Fork 27
Fix Mozilla Mercurial pushlogs URL #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @brunnopleffken, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where the Mozilla Mercurial pushlogs URL changed from hg.mozilla.org
to hg-edge.mozilla.org
. This change broke three user scripts that rely on the old URL to list fixed or modified bugs in Firefox for desktop. The PR updates the @include
attribute in each of the affected scripts to reflect the new URL.
Highlights
- URL Update: The primary change involves updating the
@include
attribute in three user scripts to use the newhg-edge.mozilla.org
URL for Mozilla Mercurial pushlogs. - Script Fixes: This PR ensures that the 'Firefox for desktop - list fixed bugs in Mercurial', 'Firefox for desktop - list fixed bugs in Mercurial as sortable table', and 'Firefox for desktop - list modified bugs in Mercurial as sortable table' scripts continue to function correctly after the URL change.
Changelog
- Firefox_for_desktop_-list_fixed_bugs_in_Mercurial/Firefox_for_desktop-_list_fixed_bugs_in_Mercurial.user.js
- Updated the
@include
attribute fromhg.mozilla.org
tohg-edge.mozilla.org
on line 9.
- Updated the
- Firefox_for_desktop_-list_fixed_bugs_in_Mercurial_as_sortable_table/Firefox_for_desktop-_list_fixed_bugs_in_Mercurial_as_sortable_table.user.js
- Updated the
@include
attribute fromhg.mozilla.org
tohg-edge.mozilla.org
on line 9.
- Updated the
- Firefox_for_desktop_-list_modified_bugs_in_Mercurial_as_sortable_table/Firefox_for_desktop-_list_modified_bugs_in_Mercurial_as_sortable_table.user.js
- Updated the
@include
attribute fromhg.mozilla.org
tohg-edge.mozilla.org
on line 9.
- Updated the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The web, it shifts and sways,
URLs change in hazy ways.
Scripts must adapt,
To dodge the trap,
Or bugs will darken all our days.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the @include
attribute in three userscripts to reflect the new domain hg-edge.mozilla.org
for Mozilla Mercurial pushlogs. This change is necessary because the old domain hg.mozilla.org
is being redirected. The PR description clearly explains the issue and the scripts affected. The changes are straightforward and address the problem effectively.
Merge Readiness
The pull request is a small but important fix that addresses a broken feature in the userscripts. The change is well-justified and the code modification is minimal and correct. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Given the nature of the fix, it seems appropriate to merge this pull request after another review.
Seems like
hg.mozilla.org
is now being redirected tohg-edge.mozilla.org
(as seen here accessing the old URL: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?startdate=1+day+ago&enddate=now). This change breaks the following scripts:This PR fixes this issue changing the
@include
attr.