Skip to content

[OPTIONS] Restore plugins option #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lihqi
Copy link

@lihqi lihqi commented Feb 20, 2025

Description

In version 1.6.1, the plugins feature was introduced, greatly enhancing our project's flexibility and extensibility. This feature has proven very useful, as my colleagues have successfully used it in our repository. However, we noticed that it was removed in version 1.7.0, which has affected our current workflow.
code

Questions and Concerns

Given the importance of the plugins feature to our work, we would like to understand the rationale behind its removal:

  • Was it due to certain bugs or issues, or was it part of an architectural change?
  • Are there alternative solutions that were considered?

Proposed Solution

This PR restores the plugins feature to address the challenges arising from its absence. If any issues persist after the reintroduction, we are more than willing to collaborate on further adjustments and improvements.

Request

  • We kindly ask the maintainers to review this PR and share any insights or discussions related to the removal of the feature.
  • If there are no significant concerns, please consider merging this PR to reinstate the plugins functionality.

Thank you for taking the time to review these changes, and for your continued support and guidance!

@lihqi lihqi changed the base branch from master to debug/v1.6.1 February 21, 2025 02:04
@lihqi lihqi changed the base branch from debug/v1.6.1 to master February 21, 2025 02:18
@lihqi
Copy link
Author

lihqi commented Feb 21, 2025

@darionco

Thank you for your prompt response and actions on this. I noticed you might already be working on addressing the changes related to this PR. To avoid overlapping efforts and ensure alignment with your implementation approach, I'll refrain from making further modifications here.

Please note that my initial commit was incomplete as it only addressed the plugins field specific to our current project's use case. Feel free to close this PR if your implementation comprehensively covers the required changes.

Appreciate your understanding and collaboration on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants