-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Quickstart for Javascript Jobs HTTP api #1134
Added Quickstart for Javascript Jobs HTTP api #1134
Conversation
Signed-off-by: Constantin Chirila <[email protected]>
a0408c1
to
4d31a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be tested without the multi-app run files and with the single dapr commands.
Signed-off-by: Constantin Chirila <[email protected]>
Thank you for the comments @alicejgibbons. |
Signed-off-by: Constantin Chirila <[email protected]>
ebdbc89
to
9884f19
Compare
``` | ||
|
||
<!-- END_STEP --> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need a step for stopping the dotnet multi app run file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConstantinChirila for when you're back, I figured out that to get the dapr stop -f .
to work you need to add background: true
in the previous step so that it wont end the app running for you.
You can look in mine if need: https://github.com/dapr/quickstarts/pull/1144/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alicejgibbons Seems to work when i validate it :)
jobs/javascript/http/README.md
Outdated
expected_stderr_lines: | ||
output_match_mode: substring | ||
match_order: none | ||
background: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background: false | |
background: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try this locally and lmk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested small changes related to #1152
Signed-off-by: Constantin Chirila <[email protected]>
Signed-off-by: Constantin Chirila <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ready to merge after Elena's PR: #1148
@@ -0,0 +1,184 @@ | |||
# Dapr Jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Dapr Jobs | |
# Dapr Jobs API (JS HTTP) |
appDirPath: ./job-service/ | ||
appPort: 6200 | ||
daprHTTPPort: 6280 | ||
schedulerHostAddress: localhost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schedulerHostAddress: localhost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are in the process of removing this line from all the quickstarts Constantin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added the missing quickstart for how to use the Dapr Jobs with Javascript through standard http fetch.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1112
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: