Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating Conversation Quickstart for Go #1128

Merged
merged 26 commits into from
Jan 23, 2025
Merged

Creating Conversation Quickstart for Go #1128

merged 26 commits into from
Jan 23, 2025

Conversation

rochabr
Copy link
Contributor

@rochabr rochabr commented Jan 14, 2025 •
edited
Loading

Description

Conversation building block SDK and HTTP quickstart samples.

@rochabr
Creating Conversation folder
cf8397a 
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr rochabr requested review from a team as code owners January 14, 2025 18:41
@rochabr rochabr changed the title Creating Conversation folder Creating Conversation Quickstart for Go Jan 21, 2025
mikeee
mikeee requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few nits

I think there are changes to non-conversation-related quickstarts/docs, I would remove those from this PR to avoid confusion

conversation/go/http/README.md Outdated Show resolved Hide resolved
conversation/go/http/README.md Outdated Show resolved Hide resolved
conversation/go/http/conversation/conversation.go Outdated Show resolved Hide resolved
conversation/go/http/conversation/go.mod Outdated Show resolved Hide resolved
conversation/go/sdk/README.md Show resolved Hide resolved
conversation/go/sdk/components/conversation.yaml Outdated Show resolved Hide resolved
conversation/go/sdk/conversation/go.mod Outdated Show resolved Hide resolved
conversation/go/sdk/conversation/go.mod Outdated Show resolved Hide resolved
conversation/go/sdk/go.mod Outdated Show resolved Hide resolved
rochabr and others added 7 commits January 21, 2025 10:13
@rochabr @mikeee
Update conversation.go
e2b6a48 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @mikeee
Update go.mod
984c9c5 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @mikeee
Update go.mod
a75d653 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr
Finishing conversation sdk and fixing components path
ea48818 
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr
Finishing conversation sdk and fixing components path
59b885c 
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @mikeee
Update conversation/go/http/README.md
92a7033 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@mikeee
Merge branch 'release-1.15' into release-1.15
ce9e3b5
mikeee
mikeee previously requested changes Jan 23, 2025
View reviewed changes
conversation/go/http/dapr.yaml Outdated Show resolved Hide resolved
conversation/go/sdk/dapr.yaml Outdated Show resolved Hide resolved
conversation/go/sdk/dapr.yaml Outdated Show resolved Hide resolved
conversation/go/http/README.md Outdated Show resolved Hide resolved
rochabr and others added 4 commits January 23, 2025 09:15
@rochabr @mikeee
Update conversation/go/sdk/dapr.yaml
695cec4 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @mikeee
Update conversation/go/http/dapr.yaml
680cf29 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @mikeee
Update conversation/go/sdk/dapr.yaml
5c32644 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr
Updating sleep and timeout times
9820c13 
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr
Copy link
Contributor Author

rochabr commented Jan 23, 2025

@alicejgibbons here

alicejgibbons
alicejgibbons requested changes Jan 23, 2025
View reviewed changes
Copy link

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things since this is the "first" conversation quickstart

tutorials/distributed-calculator/react-calculator/client/yarn.lock Outdated Show resolved Hide resolved
tutorials/distributed-calculator/react-calculator/yarn.lock Outdated Show resolved Hide resolved
conversation/go/sdk/README.md Outdated Show resolved Hide resolved
conversation/go/sdk/README.md Outdated Show resolved Hide resolved
conversation/go/sdk/README.md Outdated Show resolved Hide resolved
conversation/go/http/README.md Outdated Show resolved Hide resolved
conversation/go/http/README.md Outdated Show resolved Hide resolved
conversation/go/http/README.md Outdated Show resolved Hide resolved
conversation/go/http/README.md Outdated Show resolved Hide resolved
conversation/go/sdk/README.md Outdated Show resolved Hide resolved
rochabr and others added 6 commits January 23, 2025 10:35
@rochabr @alicejgibbons
Update conversation/go/sdk/README.md
0a8dc8b 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @alicejgibbons
Update conversation/go/http/README.md
ae9c2fb 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @alicejgibbons
Update conversation/go/http/README.md
63c2247 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @alicejgibbons
Update conversation/go/sdk/README.md
e47efba 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @alicejgibbons
Update conversation/go/http/README.md
834ab60 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr
Comversation README improvements
b4f0d21 
Signed-off-by: Fernando Rocha <[email protected]>
mikeee
mikeee reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my request for changes but the js deps modifications should be removed from the PR imo

rochabr and others added 5 commits January 23, 2025 12:32
@rochabr
Merge branch 'release-1.15' into release-1.15
dda7f50
@rochabr @alicejgibbons
Update conversation/go/http/README.md
1abe940 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @alicejgibbons
Update conversation/go/sdk/README.md
8cd76a6 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr @alicejgibbons
Update conversation/go/sdk/README.md
51b7ba5 
Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr
removing files from PR
5e29784 
Signed-off-by: Fernando Rocha <[email protected]>
alicejgibbons
alicejgibbons approved these changes Jan 23, 2025
View reviewed changes
Copy link

@alicejgibbons alicejgibbons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if just the python test fails, lets merge

mikeee
mikeee approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, solid job 👌

@paulyuk paulyuk merged commit 7000a78 into dapr:release-1.15 Jan 23, 2025
6 of 7 checks passed
@rochabr rochabr deleted the release-1.15 branch January 23, 2025 21:38
This was referenced Jan 24, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejgibbons alicejgibbons alicejgibbons approved these changes

@mikeee mikeee mikeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rochabr @alicejgibbons @mikeee @paulyuk