multi app token workflow #856
Open
+658
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iginal env var DAPR_API_TOKEN if found Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
acroca
requested changes
Oct 24, 2025
| # -*- coding: utf-8 -*- | ||
|
|
||
| """ | ||
| Copyright 2024 The Dapr Authors |
There was a problem hiding this comment.
Suggested change
| Copyright 2024 The Dapr Authors | |
| Copyright 2025 The Dapr Authors |
| falls back to DAPR_API_TOKEN environment variable. | ||
| """ | ||
| DaprHealth.wait_until_ready() | ||
| self._api_token = api_token |
There was a problem hiding this comment.
Why don't set api_token to default to settings.DAPR_API_TOKEN, and use it throughout this init function?
Suggested change
| self._api_token = api_token | |
| api_token = api_token if api_token is not None else settings.DAPR_API_TOKEN |
| """ | ||
| self._client = DaprHttpClient(message_serializer, timeout, headers_callback, retry_policy) | ||
| self._client = DaprHttpClient( | ||
| message_serializer, timeout, headers_callback, retry_policy, api_token=api_token |
There was a problem hiding this comment.
I like kv arguments, but for consistency...
Suggested change
| message_serializer, timeout, headers_callback, retry_policy, api_token=api_token | |
| message_serializer, timeout, headers_callback, retry_policy, api_token |
| class DaprHealth: | ||
| @staticmethod | ||
| def wait_until_ready(): | ||
| def wait_until_ready(api_token: str = None): |
There was a problem hiding this comment.
Suggested change
| def wait_until_ready(api_token: str = None): | |
| def wait_until_ready(api_token: Optional[str] = None): |
| raise DaprInternalError(f'{error}') from error | ||
|
|
||
| self._logger = Logger('DaprWorkflowClient', logger_options) | ||
| self._api_token = api_token |
There was a problem hiding this comment.
Does this need to go to _api_token? Can't we just use api_token directly? I don't think it's used outside of this function
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: