update protobuf version in workflow #850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acroca ptal |
acroca
approved these changes
Oct 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #850 +/- ##
===============================================
Coverage ? 87.15%
===============================================
Files ? 93
Lines ? 6164
Branches ? 0
===============================================
Hits ? 5372
Misses ? 792
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acroca
approved these changes
Oct 21, 2025
filintod
commented
Oct 22, 2025
| # protobuf dependency constrained per durabletask grpc generator | ||
| # in https://github.com/dapr/durabletask-python/blob/main/dev-requirements.txt | ||
| # check install_requires in https://github.com/grpc/grpc/blob/master/tools/distrib/python/grpcio_tools/setup.py#L349 | ||
| protobuf>=6.31.0,<7.0.0 |
There was a problem hiding this comment.
we probably should bump durabletask-dapr too
There was a problem hiding this comment.
we need to update durable task with fix for continue_as_new
Signed-off-by: Filinto Duran <[email protected]>
filintod
force-pushed
the
filinto/update-protobuf-workflows-version
branch
from
6357150 to
4b822dd
Compare
|
closing in favor of dapr/durabletask-python#26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #849
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #849
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: