Skip to content

POC: Retry with native grpc #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Feb 27, 2024

Description

This is one of the possible options we're looking at for implementing retry policies.

gRPC specifies that retry policy definitions should be defined on the service itself and transmitted to the client through the service config mechanism (https://github.com/grpc/proposal/blob/master/A6-client-retries.md). All gRPC clients are supposed to execute the retries, based on the policy.

This PR specifies the retry policy service config on the client. It's a very clean way to do it, with minimal code change, but there's two main drawbacks:

  • It doesn't handle statuses that have a RetryInfo detail where the server instructs the client when it should retry the request
  • It can not handle the requirement for infinite retries defined in our proposal, the maximum retry attempts it allows is 5.

@elena-kolevska elena-kolevska changed the title WIP: Resiliency with native grpc WIP: Retry with native grpc Feb 27, 2024
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska changed the title WIP: Retry with native grpc POC: Retry with native grpc Apr 24, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale Issue marked as stale by Dapr Bot label Jun 23, 2024
@elena-kolevska elena-kolevska deleted the resiliency-native-grpc branch February 17, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue marked as stale by Dapr Bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants