Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bulksubscribe http #478

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

lint fix

300e5ac
Select commit
Loading
Failed to load commit list.
Open

feat: bulksubscribe http #478

lint fix
300e5ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 14, 2024 in 0s

58.63% (+0.58%) compared to 27248ba

View this Pull Request on Codecov

58.63% (+0.58%) compared to 27248ba

Details

Codecov Report

Attention: Patch coverage is 75.36232% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 58.63%. Comparing base (27248ba) to head (300e5ac).
Report is 11 commits behind head on main.

Files Patch % Lines
service/http/topic.go 66.66% 21 Missing and 7 partials ⚠️
service/internal/topicregistrar.go 86.66% 2 Missing and 2 partials ⚠️
service/internal/topicsubscription.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   58.04%   58.63%   +0.58%     
==========================================
  Files          55       55              
  Lines        3568     3701     +133     
==========================================
+ Hits         2071     2170      +99     
- Misses       1375     1399      +24     
- Partials      122      132      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov