-
Notifications
You must be signed in to change notification settings - Fork 2
Update upstream #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream #12
Changes from 16 commits
d53cf5c
4a303cb
2466e7d
551cb02
37544cf
2bdf87f
6d3ad8f
75f573b
aae0267
62d2014
04fe991
e6be3d6
c9704b3
43a4453
dfec5da
25aae7d
89437eb
3439afc
76033a2
f9e2bf5
6f12d1d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
grpcio-tools==1.62.3 # 1.62.X is the latest version before protobuf 1.26.X is used which has breaking changes for Python | ||
grpcio-tools | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already tried updating this dependency and there was a long discussion about it: I see this change is coming from upstream, but I'd like to understand what changed to make us change the decision we took in the comment above, cause all the raised points should still be valid. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The upstream commit doesn't have much information about why they changed it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, let's keep it please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Changelog needs to be clarified for this fork