-
Notifications
You must be signed in to change notification settings - Fork 780
Adds documentation for $ dapr scheduler
#4909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See dapr/cli#1559 Signed-off-by: joshvanl <[email protected]>
marcduiker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this is great and will be super beneficial to users. Just some ideas around consolidating the docs into one place and linking it across the other reference sections to limit sprawl & duplication of the same information.
Also had a question around the design of the delete-all - might be worth commenting on the PR in the cli, but I reviewed this first for a better user experience perspective.
daprdocs/content/en/developing-applications/building-blocks/actors/actors-timers-reminders.md
Show resolved
Hide resolved
| dapr scheduler delete-all actor/MyActorType/actorid1 | ||
| ``` | ||
|
|
||
| #### Backup and restore reminders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we have all docs from the scheduler.md if would limit this being noted twice bc this is the same as: Export all jobs to a file:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hear you, however I think I prefer to still have this here too
Signed-off-by: joshvanl <[email protected]>
cicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me. thx!
nelson-parente
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @marcduiker can we merge it?
See dapr/cli#1559