-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs API docs, pt 3 #4243
Jobs API docs, pt 3 #4243
Conversation
Signed-off-by: Hannah Hunter <[email protected]>
@cicoyle just waiting on an example that I can base the docs how-to off of... feel free to add commits to my branch if it's easier for you to write something that I can edit later |
@hhunter-ms - Apologies for the lack of docs input. The go-sdk implementation is available: https://github.com/dapr/go-sdk/tree/58e56c0b2cd067367a3e52b4eae4210f6d62cb74/examples/dist-scheduler I don't anticipate any further changes client-wise. |
Signed-off-by: Hannah Hunter <[email protected]>
…o issue_3915-3
Signed-off-by: Hannah Hunter <[email protected]>
Stale PR, paging all reviewers |
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
@msfussell - do you think |
@@ -0,0 +1,223 @@ | |||
--- | |||
type: docs | |||
title: "How-To: Handle triggered jobs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Better to show the Go SDK methods rather than HTTP
- the code here should be a snippet that simply shows the main methods calls that you want to person to focus on. There are already full code samples here jobs quickstart #4276 otherwise we are just repeating everything.
- This HowTo (which tells you the essential points) then simply points to this code example
- Have a couple of sentences telling the person what is happening. Also does it really need to be split into two apps? People will think is what is required, when this all can be in the same app and will be 90% of the time.
- Also do not see why this should be split into 2 different topics. Just have one topic on "How to schedule and handle trigger jobs" (include scheduling and triggers)
…al example Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
log.Fatalf("failed to start server: %v", err) | ||
} | ||
}() | ||
// ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing is showing up weird here, but looks fine in my IDE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks fine when I build locally too!
Signed-off-by: Hannah Hunter <[email protected]>
.../en/developing-applications/building-blocks/jobs/howto-schedule-and-handle-triggered-jobs.md
Show resolved
Hide resolved
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
dapr init
anddocker ps
outputs to install docIssue reference
PR will close: #3915