Add bindings rocketmq #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum
|
@cinience Like with the nacos binding, I'm making tweaks to use "the settings pattern". |
# Conflicts: # go.sum
pkedy
previously approved these changes
May 11, 2021
|
/cc: @artursouza |
artursouza
approved these changes
May 13, 2021
pkedy
approved these changes
May 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 36.59% 36.07% -0.52%
==========================================
Files 127 129 +2
Lines 10283 10441 +158
==========================================
+ Hits 3763 3767 +4
- Misses 6127 6280 +153
- Partials 393 394 +1
Continue to review full report at Codecov.
|
4 tasks
Taction
added a commit
to Taction/components-contrib
that referenced
this pull request
May 21, 2021
* master: (23 commits) Add bindings dingtalk webhook (dapr#817) add BulkGetResponse comments (dapr#845) Fix race in pulsar pubsub component (dapr#868) Add pubsub rocketmq (dapr#816) Add bindings rocketmq (dapr#815) Add bindings nacos (dapr#814) Sentinel middleware support (dapr#829) Added vaultToken support (dapr#796) Update Aerospike to v4.5.0 Add function to generate CloudEvent for raw subscribed events. (dapr#864) Configurable retry (dapr#854) Update redis metadata comments to reflect the new maxRetry default from v8 (dapr#856) fix calc ipv6num use ipv4 slice (dapr#838) Do not block indefinitely on XGroupRead for redis subscriber (dapr#855) fix go mod fix lint fix add add a ctx context variable in the Redis struct. And implement `Close() error` function. fix add add a ctx context variable in the Redis struct. And implemet `Close() error` function fix use r.ctx instead of context.Background() in pubsub redis component Fixing go.mod ... # Conflicts: # secretstores/hashicorp/vault/vault.go # secretstores/hashicorp/vault/vault_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A binding that allows reading / writing from Alibaba Cloud RocketMQ.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #812
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: