Skip to content

Comment exited consolidation #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Comment exited consolidation #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions oracle/oracle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3306,29 +3306,30 @@ func Test_ValidatorCleanup_Consolidations(t *testing.T) {
require.Equal(t, big.NewInt(0), oracle.state.PoolAccumulatedFees)
})

t.Run("Test7: Consolidation target is exited – fallback to pool", func(t *testing.T) {
oracle := NewOracle(&Config{Network: "mainnet"})
oracle.state.Validators[80] = &ValidatorInfo{PendingRewardsWei: big.NewInt(999), ValidatorStatus: Active}
oracle.state.Validators[81] = &ValidatorInfo{PendingRewardsWei: big.NewInt(0), ValidatorStatus: Active}

oracle.SetGetSetOfValidatorsFunc(func(_ []phase0.ValidatorIndex, _ string, _ ...retry.Option) (map[phase0.ValidatorIndex]*v1.Validator, error) {
return map[phase0.ValidatorIndex]*v1.Validator{
80: {Index: 80, Status: v1.ValidatorStateExitedUnslashed},
81: {Index: 81, Status: v1.ValidatorStateExitedUnslashed},
}, nil
})
oracle.GetPendingConsolidationsFunc(func(stateID string, opts ...retry.Option) (*PendingConsolidationsResponse, error) {
return &PendingConsolidationsResponse{Data: []PendingConsolidation{
{SourceIndex: 80, TargetIndex: 81},
}}, nil
})

err := oracle.ValidatorCleanup(mainnetElectra + 1)
require.NoError(t, err)
require.Equal(t, big.NewInt(0), oracle.state.Validators[80].PendingRewardsWei)
require.Equal(t, big.NewInt(999), oracle.state.PoolAccumulatedFees)
require.Equal(t, NotSubscribed, oracle.state.Validators[80].ValidatorStatus)
})
// TODO: this will never happen, a consolidation can not be done to a validator that is exited
// t.Run("Test7: Consolidation target is exited – fallback to pool", func(t *testing.T) {
// oracle := NewOracle(&Config{Network: "mainnet"})
// oracle.state.Validators[80] = &ValidatorInfo{PendingRewardsWei: big.NewInt(999), ValidatorStatus: Active}
// oracle.state.Validators[81] = &ValidatorInfo{PendingRewardsWei: big.NewInt(0), ValidatorStatus: Active}

// oracle.SetGetSetOfValidatorsFunc(func(_ []phase0.ValidatorIndex, _ string, _ ...retry.Option) (map[phase0.ValidatorIndex]*v1.Validator, error) {
// return map[phase0.ValidatorIndex]*v1.Validator{
// 80: {Index: 80, Status: v1.ValidatorStateExitedUnslashed},
// 81: {Index: 81, Status: v1.ValidatorStateExitedUnslashed},
// }, nil
// })
// oracle.GetPendingConsolidationsFunc(func(stateID string, opts ...retry.Option) (*PendingConsolidationsResponse, error) {
// return &PendingConsolidationsResponse{Data: []PendingConsolidation{
// {SourceIndex: 80, TargetIndex: 81},
// }}, nil
// })

// err := oracle.ValidatorCleanup(mainnetElectra + 1)
// require.NoError(t, err)
// require.Equal(t, big.NewInt(0), oracle.state.Validators[80].PendingRewardsWei)
// require.Equal(t, big.NewInt(999), oracle.state.PoolAccumulatedFees)
// require.Equal(t, NotSubscribed, oracle.state.Validators[80].ValidatorStatus)
// })

}

Expand Down