Skip to content

Fix Merge Conflict #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e9cb269
CW-prod-privacy-policy Added privacy policy page
MeyerPV Apr 3, 2024
dbaf198
Merge pull request #2670 from daostack/CW-prod-privacy-policy-page
MeyerPV Apr 3, 2024
9ecf7cd
CW-prod-policy fix privacy-policy path
MeyerPV Apr 9, 2024
c74f7c4
Merge pull request #2678 from daostack/CW-prod-policy
MeyerPV Apr 9, 2024
7f744d5
Merge branch 'staging'
andreymikhadyuk Apr 9, 2024
b295c5f
CW-staging-privacy-policy Fixed privacy policy url
MeyerPV Apr 10, 2024
0eb7195
Merge pull request #2681 from daostack/CW-staging-privacy-policy
MeyerPV Apr 10, 2024
157e4c7
add experimentalForceLongPolling to firestore settings
andreymikhadyuk Apr 16, 2024
400d050
CW-Webview-fix-backbutton Fixed back-button redirect
MeyerPV Apr 21, 2024
4543182
Merge pull request #2688 from daostack/CW-Webview-fix-backbutton
MeyerPV Apr 21, 2024
10f0acb
Merge branch 'dev' into staging
andreymikhadyuk Apr 25, 2024
1ecbd61
Merge branch 'staging'
andreymikhadyuk May 9, 2024
98d5fcb
Merge pull request #2693 from daostack/dev
elatif2020 May 21, 2024
836e6fb
Merge pull request #2695 from daostack/dev
MeyerPV May 27, 2024
fa455b0
Merge pull request #2698 from daostack/dev
MeyerPV Jun 10, 2024
6e54820
Merge pull request #2699 from daostack/staging
MeyerPV Jun 11, 2024
fd6b3ba
Merge pull request #2710 from daostack/dev
MeyerPV Jul 2, 2024
98aab31
Merge pull request #2713 from daostack/dev
MeyerPV Jul 8, 2024
335286b
Merge pull request #2714 from daostack/staging
MeyerPV Jul 10, 2024
567554a
Merge pull request #2725 from daostack/dev
MeyerPV Aug 27, 2024
3e2ea1f
Merge pull request #2728 from daostack/dev
MeyerPV Aug 28, 2024
417883f
Merge pull request #2726 from daostack/staging
MeyerPV Aug 28, 2024
4f0d7cc
CW-hotfix-app-crash
MeyerPV Sep 2, 2024
f5d9c71
CW-hotfix-app-crash
MeyerPV Sep 2, 2024
f572fee
Merge pull request #2731 from daostack/CW-hotfix-app-crash
MeyerPV Sep 3, 2024
6ed41ac
Merge branch 'dev' into CW-fix-confliсе
MeyerPV Oct 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/pages/OldCommon/hooks/useCommonMembers.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useCallback, useRef, useState } from "react";
import { useDispatch, useSelector } from "react-redux";
import { trace } from "firebase/performance";
import { CommonService, Logger, UserService } from "@/services";
import { store } from "@/shared/appConfig";
import { LoadingState } from "@/shared/interfaces";
Expand All @@ -11,7 +10,6 @@ import {
selectUserStates,
} from "@/store/states";
import { useDeepCompareEffect } from "react-use";
import { perf } from "@/shared/utils/firebase";

interface Options {
commonId?: string;
Expand Down Expand Up @@ -113,9 +111,6 @@ export const useCommonMembers = ({ commonId }: Options): Return => {

(async () => {
try {
const useCommonMembersTrace = trace(perf, 'useCommonMembers');
useCommonMembersTrace.start();

const cachedUserStates = selectUserStates()(store.getState());
const hasUsersFromCache = commonMembers.some(
({ userId }) => cachedUserStates[userId]?.data,
Expand Down Expand Up @@ -188,7 +183,6 @@ export const useCommonMembers = ({ commonId }: Options): Return => {
};
});
dispatch(cacheActions.updateUserStates(fetchedUsers));
useCommonMembersTrace.stop();
} catch (err) {
Logger.error(err);
setState((prevState) => ({
Expand Down
5 changes: 1 addition & 4 deletions src/pages/PrivacyPolicy/PrivacyPolicy.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ import "./PrivacyPolicy.scss";
export function PrivacyPolicy() {
return (
<div className="container-pdf">
<Document
className="preview-pdf"
file="http://localhost:3000/privacy_policy.pdf"
>
<Document className="preview-pdf" file="/privacy_policy.pdf">
<Page pageNumber={1} />
<Page pageNumber={2} />
<Page pageNumber={3} />
Expand Down
2 changes: 1 addition & 1 deletion src/pages/PrivacyPolicy/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export * from "./PrivacyPolicy";
export * from "./PrivacyPolicy";
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,7 @@ interface ProjectProps {
}

const Project: FC<ProjectProps> = (props) => {
const {
title,
url,
imageURL,
imageAlt,
tooltipContent,
} = props;
const { title, url, imageURL, imageAlt, tooltipContent } = props;

const contentEl = (
<div className={styles.item}>
Expand Down
15 changes: 3 additions & 12 deletions src/shared/hooks/useCases/useDiscussionMessagesById.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { useState, useCallback, useEffect, useRef } from "react";
import { useDispatch, useSelector } from "react-redux";
import { useDeepCompareEffect, useUpdateEffect } from "react-use";
import { trace } from "firebase/performance";
import {
DiscussionMessageService,
MESSAGES_NUMBER_IN_BATCH,
Expand All @@ -21,7 +20,7 @@ import {
User,
} from "@/shared/models";
import { InternalLinkData } from "@/shared/utils";
import firebase, { perf } from "@/shared/utils/firebase";
import firebase from "@/shared/utils/firebase";
import {
cacheActions,
selectDiscussionMessagesStateByDiscussionId,
Expand Down Expand Up @@ -156,10 +155,7 @@ export const useDiscussionMessagesById = ({

const fetchRepliedMessages = useCallback(
async (messageId: string, endDate: Date): Promise<void> => {
const fetchRepliedMessagesTrace = trace(perf, 'fetchRepliedMessagesTrace');
try {
fetchRepliedMessagesTrace.start();

if (state.data?.find((item) => item.id === messageId)) {
return Promise.resolve();
}
Expand Down Expand Up @@ -213,9 +209,8 @@ export const useDiscussionMessagesById = ({
updatedDiscussionMessages: discussionsWithText,
}),
);
fetchRepliedMessagesTrace.stop();
} catch(err) {
fetchRepliedMessagesTrace.stop();
// console.log(err);
}
},
[
Expand Down Expand Up @@ -250,9 +245,6 @@ export const useDiscussionMessagesById = ({
}

try {
const fetchDiscussionMessagesTrace = trace(perf, 'fetchDiscussionMessages');
fetchDiscussionMessagesTrace.start();

unsubscribeRef.current = DiscussionMessageService.subscribeToDiscussionMessagesByDiscussionId(
discussionId,
lastVisible && lastVisible[discussionId],
Expand Down Expand Up @@ -322,8 +314,7 @@ export const useDiscussionMessagesById = ({
setIsBatchLoading(false);
},
);
fetchDiscussionMessagesTrace.stop();
} catch (err) {
} catch(err) {
setIsBatchLoading(false);
}
}, [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const FeedItemBreadcrumbs: FC<FeedItemBreadcrumbsProps> = ({
});

return () => {
unsubscribe();
unsubscribe && unsubscribe();
};
}, [breadcrumbs.activeItem?.id]);

Expand Down
Loading