Skip to content

Use _WIN32 only to check for windows #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use _WIN32 only to check for windows #531

wants to merge 1 commit into from

Conversation

glankk
Copy link
Contributor

@glankk glankk commented Sep 2, 2025

Removes __CYGWIN__ and __MINGW32__ checks, as well as the SIMPLECPP_WINDOWS macro, in favor of _WIN32. Needed for #475.

@glankk glankk mentioned this pull request Sep 2, 2025
Open
@firewave
Copy link
Collaborator

firewave commented Sep 2, 2025

Let's focus on #524 for now and leave the NonExistingFilesCache stuff under SIMPLECPP_WINDOWS.

@firewave
Copy link
Collaborator

firewave commented Sep 2, 2025

And please mention the ticket it fixes in the title.

@danmar
Copy link
Owner

danmar commented Sep 9, 2025

Yes.. in general it is better to use _WIN32 to check if windows is used.

@firewave firewave marked this pull request as draft September 10, 2025 09:44
@firewave firewave mentioned this pull request Sep 12, 2025
Open
@firewave
Copy link
Collaborator

I published #541 as a replacement.

@firewave firewave closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glankk @firewave @danmar