Fix #391 (__TIME__ replacement might be empty depending on compiler)
#441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please create an issue. |
|
We need a test that actually triggers the issue first. I will add MinGW workflow to the CI. |
glankk
changed the title
__TIME__ replacement might be empty depending on compiler)
|
I started working on the MinGW CI in #475 (sorry it took so long) but that also exposed a number of different issues which should be looked at first. |
|
Actually #475 confirmed that this fails and requires this change to succeed. So merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
%Tformat specifier forstrftimeis somehow still not implemented in mingw-w64, causing simplecpp to expand__TIME__to an empty string. This is an issue with the compiler suite, but the easiest fix is to use the equivalent%H:%M:%Sinstead. C99's%Tis defined to be equivalent to%H:%M:%S, so this change should be compatible with all implementations supportingstrftime.