Library: reduced amount of XMLElement::Attribute() calls in loadFunction()#8233
Library: reduced amount of XMLElement::Attribute() calls in loadFunction()#8233firewave wants to merge 1 commit intodanmar:mainfrom
XMLElement::Attribute() calls in loadFunction()#8233Conversation
|
Ir in the parent process:
This should mainly help with |
firewave
force-pushed
the
loadlib-attr
branch
from
04760e9 to
d234d74
Compare
firewave
changed the title
XMLElement::Attribute() calls in loadFunction() [skip ci]XMLElement::Attribute() calls in loadFunction()
|
|
callgrind in CI: |
| } else if (functionnodename == "returnValue") { | ||
| if (const char *expr = functionnode->GetText()) | ||
| mData->mReturnValue[name] = expr; | ||
| if (const char *type = functionnode->Attribute("type")) |
There was a problem hiding this comment.
this original code is more natural and readable imho than the new code. The Ir benefit is small. Do you measure a full analysis of a project or just analysis of some file?
There was a problem hiding this comment.
In this case I measured the start-up only. Like I said it will mainly help the tests where we load a lot of libraries. It's a 2% gain and more is possible.
2 participants
No description provided.