Skip to content

Fix #14409 FP constVariableReference with pointer reference #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

Fix #14409 FP constVariableReference with pointer reference #8131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1857,10 +1857,13 @@ void CheckOther::checkConstPointer()
if (!var->isLocal() && !var->isArgument())
continue;
const Token* const nameTok = var->nameToken();
if (tok == nameTok) {
if (tok == nameTok && var->isLocal() && !astIsRangeBasedForDecl(nameTok)) {
if (var->isReference() && var->isPointer()) {
nonConstPointers.emplace(var);
continue;
}
// declarations of (static) pointers are (not) split up, array declarations are never split up
if (var->isLocal() && (!var->isStatic() || Token::simpleMatch(nameTok->next(), "[")) &&
!astIsRangeBasedForDecl(nameTok))
if ((!var->isStatic() || Token::simpleMatch(nameTok->next(), "[")))
continue;
}
// Skip function pointers
Expand Down
6 changes: 6 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3996,6 +3996,12 @@ class TestOther : public TestFixture {
" return static_cast<const D&>(b).i;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:9:10]: (style) Parameter 'b' can be declared as reference to const [constParameterReference]\n", errout_str());

check("void f(int *p) {\n" // #14409
" int*& pp{ p };\n"
" if (*pp) {}\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void constParameterCallback() {
Expand Down
Loading