fixed #14347 - fixed Clang warnings in C++20 build #8021
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
cxx20
branch
2 times, most recently
from
774d19d to
7a010b5
Compare
firewave
changed the title
-Wdeprecated-this-capture Clang C++20 warning
firewave
changed the title
Collaborator
Author
|
The CI jobs will not trigger the warnings which have been fixed by this. A Clang build is implicitly performed by the clang-tidy job. We could switch that job to a higher standard (C++23 even) and adjust the configuration accordingly. This would also allow us to introduce some more conditional modernizations. |
firewave
force-pushed
the
cxx20
branch
3 times, most recently
from
2260091 to
c107e0e
Compare
Collaborator
Author
not true - macOS obviously uses Clang... |
Collaborator
Author
|
The C++20 builds fails for macOS: |
example:
```
/home/user/CLionProjects/cppcheck/lib/pathmatch.cpp:37:37: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
37 | return match(pattern, path, mBasepath, mode, mSyntax);
| ^
/home/user/CLionProjects/cppcheck/lib/pathmatch.cpp:36:63: note: add an explicit capture of 'this' to capture '*this' by reference
36 | return std::any_of(mPatterns.cbegin(), mPatterns.cend(), [=] (const std::string &pattern) {
| ^
| , this
```
|
danmar
reviewed
Jan 12, 2026
| auto *action = new QAction(tr("No tag"), tagMenu); | ||
| tagMenu->addAction(action); | ||
| connect(action, &QAction::triggered, [=]() { | ||
| connect(action, &QAction::triggered, [EXPLICIT_THIS]() { |
Owner
There was a problem hiding this comment.
can't this be rewritten so it's compatible both with c++20 and c++14 ? [this] ?
| auto *action = new QAction(tagstr, tagMenu); | ||
| tagMenu->addAction(action); | ||
| connect(action, &QAction::triggered, [=]() { | ||
| connect(action, &QAction::triggered, [EXPLICIT_THIS]() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.