Skip to content

Fix 14137: False positive: uninitvar when using an assert before loop #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Fix 14137: False positive: uninitvar when using an assert before loop #7828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f297332
Fix 14137: False positive: uninitvar when using an assert before loop
pfultz2 Sep 16, 2025
3b63618
Format
pfultz2 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/programmemory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,16 @@ static void fillProgramMemoryFromAssignments(ProgramMemory& pm, const Token* tok
pm.setValue(vartok, execute(valuetok, pm, settings));
}
}
} else if (Token::simpleMatch(tok2, ")") && tok2->link() &&
Token::Match(tok2->link()->previous(), "assert|ASSERT ( !!)")) {
const Token* cond = tok2->link()->astOperand2();
if (!conditionIsTrue(cond, state, settings)) {
// TODO: change to assert when we can propagate the assert, for now just bail
if (conditionIsFalse(cond, state, settings))
return;
programMemoryParseCondition(pm, cond, nullptr, settings, true);
}
tok2 = tok2->link()->previous();
} else if (tok2->exprId() > 0 && Token::Match(tok2, ".|(|[|*|%var%") && !pm.hasValue(tok2->exprId()) &&
isVariableChanged(tok2, 0, settings)) {
pm.setUnknown(tok2);
Expand Down
10 changes: 10 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7667,6 +7667,16 @@ class TestUninitVar : public TestFixture {
" }\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3:24]: (error) Uninitialized variable: b [uninitvar]\n", errout_str());

// #14137
valueFlowUninit("int f(int n) {\n"
" int x;\n"
" assert(n > 0);\n"
" for(int i=0;i<n;i++)\n"
" x = n;\n"
" return x;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void uninitvar_memberfunction() {
Expand Down