Fix #12910 FP containerOutOfBounds with overloaded template function

[chrchr-github]

Feels hacky though.

[danmar]

Suggested change

	return startsWith(f.name(), tok->str()) && f.name().size() > nTok + 2 && f.name()[nTok + 1] == '<';
	return startsWith(f.name(), tok->str() + "<") && f.name().size() > nTok + 2;

I still feel it's hacky but this seems better.

[chrchr-github]

The function name seems to be func < arg > instead of func<arg> for some reason.

[danmar]

yeah there is (sometimes?) space before the "<" . we did not used to have it. maybe the extra spaces are removed in the future again who knows.

[firewave]

If you have examples for either case I will see if I can bisect this.

[chrchr-github]

If you have examples for either case I will see if I can bisect this.

The spaces appear in the output of --debug -v (e.g. name:), but I don't know what the significance is.

[firewave]

template <class T> void fun()
{
}

int main()
{
    fun<int>();
}

1.77

1:
|
4:
5: int main ( )
6: {
7: fun<int> ( ) ;
8: } void fun<int> ( )
2: {
3: }
[...]
Scope: 000001F7E6853E30 Function
    className: fun<int>
[...]
##AST
( 'signed int'
`-main

( 'void'
`-fun<int>

( 'void'
`-fun<int>

1.78

1:
|
4:
5: int main ( )
6: {
7: fun < int > ( ) ;
8: } void fun < int > ( )
2: {
3: }
[...]
Scope: 000001CBB41650D0 Function
    className: fun < int >
[...]
##AST
( 'signed int'
`-main

( 'void'
`-fun < int >

( 'void'
`-fun < int >

1.82

1:
|
4:
5: int main ( )
6: {
7: fun<int> ( ) ;
8: } void fun<int> ( )
2: {
3: }
[...]
Scope: 000001E34CC268D0 Function
    className: fun < int >
[...]
##AST
( 'signed int'
`-main

( 'void'
`-fun < int >

( 'void'
`-fun < int >

[firewave]

The 1.78 change has been bisected to 0943b21.

The 1.82 change has been bisected to eaadfb3.

If we make any changes we should add unit and Python tests for this.

[firewave]

Something in here we need to file a ticket about?

[chrchr-github]

The inconsistent use of spaces in template names, perhaps.

[chrchr-github]

https://trac.cppcheck.net/ticket/13781

[danmar]

Feels hacky though.

I agree.. it feels like there could be cases that does not work as wanted.

[danmar]

well I can accept this. If the space is removed in the future we'll have to change this.