Fix TypeScript type errors across multiple skills #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prompting Tools: Add null checks for regex match results in ValidateTemplate.ts, fix HandlebarsTemplateDelegate type in RenderTemplate.ts - ReportTemplate: Fix import path casing (@/components -> @/Components, @/lib -> @/Lib) - DashboardTemplate: Fix import path casing across all files, add DOM libs to tsconfig, fix React.Node -> React.ReactNode, add missing deps - Browser skill: Add allowImportingTsExtensions to tsconfig for .ts extension imports Co-Authored-By: Claude Opus 4.5 <[email protected]>
neilsoult
reviewed
Jan 30, 2026
|
|
||
| for (let i = 0; i < lines.length; i++) { | ||
| const line = lines[i]; | ||
| const line = lines[i]!; |
There was a problem hiding this comment.
I don't love hacks like this in typescript. I think it's far better to use safe access operators and use default values rather than tell typescript to basically ignore typesafety on this const.
Suggested change
| const line = lines[i]!; | |
| const line = lines[i] ?? ''; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bunx tsc --noEmitin each affected project🤖 Generated with Claude Code