fix: Eliminate command injection vulnerabilities in shell commands#488
Open
txmyer-dev wants to merge 1 commit intodanielmiessler:mainfrom
Open
fix: Eliminate command injection vulnerabilities in shell commands#488txmyer-dev wants to merge 1 commit intodanielmiessler:mainfrom
txmyer-dev wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
Replace shell-interpolated execSync calls with safer alternatives: - UpdateTabTitle: Use execFileSync with argument arrays for kitty/kitten - UpdateTabTitle: Use fetch() instead of curl for voice notifications - UpdateTabTitle: Write escape sequences directly to stderr - WhoisParser: Use execFile with input validation for whois queries - BountyPrograms: Use fs.mkdir instead of shell mkdir Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSynccalls withexecFileSyncusing argument arrayscurlwith nativefetch()API$template shell commands withexecFileandfs.mkdirFiles Changed
Packs/pai-hook-system/src/hooks/UpdateTabTitle.hook.tsPacks/pai-recon-skill/src/tools/WhoisParser.tsPacks/pai-recon-skill/src/tools/BountyPrograms.tsTest plan
; rm -rf /🤖 Generated with Claude Code