Skip to content

WIP: Implement full support for Google well-known types #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

WIP: Implement full support for Google well-known types #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a1e1b3
Update well-known types
ported-pw May 30, 2022
5ead759
mostly working serialisation
ported-pw Jun 2, 2022
b43c882
only some deserialization problems now
ported-pw Jun 8, 2022
1801b55
some cleanup, make ListValue work
ported-pw Jun 8, 2022
d45f64a
better test case for struct
ported-pw Sep 29, 2022
00dce35
this is probably better?
ported-pw Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
471 changes: 302 additions & 169 deletions src/betterproto/__init__.py
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 15 additions & 0 deletions src/betterproto/compile/importing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,21 @@ def get_type_reference(
elif source_type == ".google.protobuf.Timestamp":
return "datetime"

elif source_type == ".google.protobuf.Value":
# TODO replace `Any` with recursive type in self-reference
return "Union[None, int, float, str, bool, Dict[str, AnyType], List[AnyType]]"

elif source_type == ".google.protobuf.ListValue":
# TODO replace list item with Value type
return "List[Union[None, int, float, str, bool, Dict[str, AnyType], List[AnyType]]]"

elif source_type == ".google.protobuf.Struct":
# TODO replace `Any` with Value type
return "Dict[str, AnyType]"

elif source_type == ".google.protobuf.NullValue":
return "None"

source_package, source_type = parse_source_type_name(source_type)

current_package: List[str] = package.split(".") if package else []
Expand Down
Loading