Grpcio support #328
Grpcio support #328
Conversation
INCLUDE_GOOGLE option is now parsed in parse_options.
We now have a grpcio module in betterproto that defines the ServicerBase Abstract Base Class and a register_servicers function. Register_servicers takes multiple ServicerBase instances, and registers them to the grpc AIO server. The generated servicers now inherit from ServicerBase.
|
Hello, thank you for this contribution If you could address the conflicts, I will give it a review afterwards and look to merge |
|
@jalaziz are you still working on this? If not, I'm happy to help or take it over. |
|
Hi all, I'm also very interested in this PR. I am experiencing a bug with grpclib. Switching to grpcio (but dropping betterproto to do the codegen :/) solves the problem. I am trying to debug this, but also, grpclib doesn't have the open telemetry support that grpcio has. And grpclib doesn't seem to receive as much love as it should. All this makes grpclib a bit risky in a real prod setting. Also, I really love the simplicity of betterproto and the code it generates. Getting something usable without it is a bit painful and feels brittle, and the output still isn't as nice as betterproto. That's why I think having the choice for a backend would be a big plus. I'm happy to contribute (code and/or test) if help is required to get this PR merged. |
This is a rebased version of #201. I still haven't done any testing.
The intention is to continue the work started in #201, add tests, and address any remaining issues.